bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

11474 Updated layouts and styles in some components #116

Closed severinbeauvais closed 2 years ago

severinbeauvais commented 2 years ago

Issue #: /bcgov/entity#11474

Description of changes:

THIS IS A MINOR BREAKING CHANGE, since these components not longer render their own "surrounding" v-card; they are now more pure/atomic (div only). The parent page that uses these components will need to wrap these in a v-card / section / sheet / whatever else the parent wants to do to display this component consistently with its other components.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 2 years ago

Were some requirements updated for these components? Do they still align in there current implementations in the Edit UI as well?

These were implicit requirements: as part of layout cleanup in Create UI for registrations, I took this opportunity to remove the wrappers (v-cards in this case) from these components. The v-cards have styling that should not be baked in to these shared components; they should be more pure -- and leave wrapper styling to the parent page. You will see in my forthcoming Create UI PR that the parent pages no longer reach deep (::v-deep) into various components to override their styles; the pages now simply style the components consistently with the other components on their page. (Also these components are now responsive.)

No, you cannot pull these into Edit UI directly. I will update the release numbers for these components to indicate a "major" change. Edit UI can continue to use the old components, or even better: import the new components and wrap them with a v-card or whatever is needed. These are layout changes only (no functional changes).

severinbeauvais commented 2 years ago

Here are the new version numbers:

Changes:
 - @bcrs-shared-components/certify: 1.0.34 => 2.0.0
 - @bcrs-shared-components/contact-info: 1.0.31 => 1.1.0
 - @bcrs-shared-components/court-order-poa: 1.0.23 => 2.0.0
 - @bcrs-shared-components/staff-payment: 1.1.4 => 2.0.0

Note that I only changed ContactInfo to a new minor version since I didn't un-vcard that one (responsive column changes only).