search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

Shared Completing Party Component #125

Closed cameron-eyds closed 2 years ago

cameron-eyds commented 2 years ago

Issue #: /bcgov/entity#11742

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

cameron-eyds commented 2 years ago

Looks good!

Thank you! Still looking at how to better support the Story for these Common Components who have a multitude of dependencies.

severinbeauvais commented 2 years ago

Still looking at how to better support the Story for these Common Components who have a multitude of dependencies.

Can the dependencies be eliminated? Passed in as parameters instead of implicit?

Should this component live in sbc-common-components due to its more complex nature and dependencies?

cameron-eyds commented 2 years ago

Still looking at how to better support the Story for these Common Components who have a multitude of dependencies.

Can the dependencies be eliminated? Passed in as parameters instead of implicit?

Should this component live in sbc-common-components due to its more complex nature and dependencies?

I think i was overthinking it (yes, definitely too much thinking). The storybook error wasn't based on the common components means of fetching data but on the sub (Vue) components it was using. I needed to give story a vuetify instance to work with. For whatever reason, the components will mount/function properly at the root level, but without vuetify being passed into the story, the sub components would take issue. I wish i had more answers lol. Just my findings so far :)