bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

change spacing to 5px between labels #136

Closed meganawong closed 2 years ago

meganawong commented 2 years ago

Issue #: /bcgov/entity#12629

Description of changes: Added 5px spacing between labels in document delivery section as per Yui's direction.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

meganawong commented 2 years ago

before: Screen Shot 2022-07-15 at 11 31 35 AM after: Screen Shot 2022-07-15 at 11 32 07 AM

severinbeauvais commented 2 years ago

Also, if you follow the instructions in the README, you should update StoryBook and commit those changes too.

severinbeauvais commented 2 years ago

This fix broke the spacing when Completing Party is not editable:

image

I fixed it in this commit and now the spacing is correct in both cases:

image

image