search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

13399 Certify component not displaying red error bar and texts #144

Closed lewischenstudio closed 2 years ago

lewischenstudio commented 2 years ago

Issue #: /bcgov/entity#13399

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

lewischenstudio commented 2 years ago

Steps I did on my local environment:

image

image

severinbeauvais commented 2 years ago

Steps I did on my local environment:

  • I ran storybook to verify the "invalidSection" variable is working properly.
  • I used Node 12 and ran npm i successfully without affecting the package-lock.json file
  • I ran npm run storybook:build which updated too many files inside doc folder, which wasn't committed.

Good. Good. Not good. Usually it's just a handful of files. Did you build SB under Node 12?

If you can't sort out the SB files, I'd prefer that you didn't commit any of them, instead of checking in a mess for someone else to fix later. (Someone else can try rebuilding SB and checking in the handful of changes. In the meantime, it means people can't use SB to see your changes. But I think this is the lesser of 2 evils.)

severinbeauvais commented 2 years ago

@cameron-freshworks I added you as a reviewer since I'm away most of next week, and you know this project well. Thanks :)

cameron-eyds commented 2 years ago

@lewischenstudio Sorry Lewis, since i just jumped into this, could i get a little context on the bug and where this occurs? From a quick look into some of the local instances of this component, i can see that border and label colour take effect when prompted, so i'm confused as to what the bug is?

From Dev:

Screen Shot 2022-08-22 at 10 32 43 AM

My only concern is that if it works in some implementations and not others, potentially it's not a component issue but an implementation issue.

lewischenstudio commented 2 years ago

Oh wow! The error bar and texts DO take place when the checkbox is unchecked on Dev. I checked it on Friday, and they didn't take place. That's why I created this ticket. Maybe you are right. Maybe I didn't check it on Dev but on my local work instead, which didn't have the correct implementation to trigger the error bars. It's likely that way. I will close this PR and ticket and look into my implementation. Thanks a lot @cameron-freshworks @severinbeauvais

severinbeauvais commented 2 years ago

PS Tickets need to be approved before you work on them.

My fault I didn't catch this earlier.

cameron-eyds commented 2 years ago

Oh wow! The error bar and texts DO take place when the checkbox is unchecked on Dev. I checked it on Friday, and they didn't take place. That's why I created this ticket. Maybe you are right. Maybe I didn't check it on Dev but on my local work instead, which didn't have the correct implementation to trigger the error bars. It's likely that way. I will close this PR and ticket and look into my implementation. Thanks a lot @cameron-freshworks @severinbeauvais

No problem at all sir, thanks for looking into this! In oder to get this invalid state, i tried to submit the filing in an invalid state which was prompting the validations on the review step 👍

lewischenstudio commented 2 years ago

PS Tickets need to be approved before you work on them.

My fault I didn't catch this earlier.

It's not your fault, and you are right. I will be very careful next time in creating a ticket. I thought this is a quick fix and I checked it on Dev, but turned out I wasn't looking at the right environment. Sorry for the trouble.

lewischenstudio commented 2 years ago

Oh wow! The error bar and texts DO take place when the checkbox is unchecked on Dev. I checked it on Friday, and they didn't take place. That's why I created this ticket. Maybe you are right. Maybe I didn't check it on Dev but on my local work instead, which didn't have the correct implementation to trigger the error bars. It's likely that way. I will close this PR and ticket and look into my implementation. Thanks a lot @cameron-freshworks @severinbeauvais

No problem at all sir, thanks for looking into this! In oder to get this invalid state, i tried to submit the filing in an invalid state which was prompting the validations on the review step 👍

That is right. Thanks again for verifying it on Dev. ❤️