bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

13021 - Part 2 - Update storybook files. #146

Closed seeker25 closed 2 years ago

seeker25 commented 2 years ago

Issue #: /bcgov/entity#13021

Description of changes: Update storybook files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

seeker25 commented 2 years ago

Yes node v12.22.12*

seeker25 commented 2 years ago

Let me try again

seeker25 commented 2 years ago

No changes..

nvm use 12.22.12
npm i 
npm i --global lerna

trav@STOMP-COMP:~/work/bcrs-shared-components$ lerna bootstrap --hoist
info cli using local version of lerna
lerna notice cli v3.22.1
lerna info versioning independent
lerna info Bootstrapping 25 packages
lerna info Installing external dependencies
lerna info hoist Installing hoisted dependencies into root
lerna info hoist Pruning hoisted dependencies
lerna info hoist Finished pruning hoisted dependencies
lerna info hoist Finished bootstrapping root
lerna info Symlinking packages and binaries
lerna success Bootstrapped 25 packages
trav@STOMP-COMP:~/work/bcrs-shared-components$ npm run storybook:build
trav@STOMP-COMP:~/work/bcrs-shared-components$ npm run storybook
trav@STOMP-COMP:~/work/bcrs-shared-components$ lerna --v
5.4.3
trav@STOMP-COMP:~/work/bcrs-shared-components$ node -v
v12.22.12
severinbeauvais commented 2 years ago

Weird. When I do it (using node v 12.22.8), I only see 3 diffs:

image

severinbeauvais commented 2 years ago

Same when I use node 12.22.12:

image

severinbeauvais commented 2 years ago

Let's close this PR and please review this one instead: https://github.com/bcgov/bcrs-shared-components/pull/147

We can figure this out later. I'm swamped today.