padding for action-chip on share structures

[lambert-alex]

Issue #: /bcgov/entity#13106

Description of changes:

• added padding on action chip for share structure
• update version 2.0.4

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[lambert-alex]

To finish the rest of 13106 I will be making a PR on the edit-ui once this PR is merged. This was the easiest way to fix the action chip.

[lewischenstudio]

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

[lambert-alex]

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

I will update my PR after following the readme

[severinbeauvais]

Did you follow the Readme steps and run storybook and lerna in your local environment? There might be some changes in the docs folder that should be updated in this PR.

I believe Lewis is talking about Storybook. And he's right: you need to rebuild SB and commits its files. There should only be a handful. If there are more then you may be using the wrong Node version to run npm.

[severinbeauvais]

This seems like a lot of files being changed I am using node 12 so it should be right. Does this seem like to many

Yes, that's too many files, an indication that some version doesn't match. Last time I changed something in here, there were 3 changed files. Faiz or Travis had trouble with this recently, even after confirming their Node version.

Try this:

cd bcrs-shared-components
git co -b testing
git fetch --all
git reset --hard origin/main
nvm use 12
npm install
lerna bootstrap --hoist
npm run storybook:build
git status

If this doesn't work then (a) I can rebuild Storybook for you, or (b) we can dig in and find out why it's not working. Let me know.

[lambert-alex]

Ya this is what I get when I do that. What version of node 12 are you using? I am using 12.22.12 I wonder if that is the difference?

[severinbeauvais]

I'm using the same version of Node as you:

Your vendors-main bundle should not have changed, since you didn't change any vendor (imported packages) files.

Do you want to try to resolve this now (for everyone), or just check in the changed file and I'll commit the SB changes for you?

[lambert-alex]

I'm using the same version of Node as you:

Your vendors-main bundle should not have changed, since you didn't change any vendor (imported packages) files.

Do you want to try to resolve this now (for everyone), or just check in the changed file and I'll commit the SB changes for you?

I would be willing to try and fix it for everyone

[severinbeauvais]

I would be willing to try and fix it for everyone

I think maybe it was me all along! I recreated the repo and followed the steps in the readme, and saw that the vendor files had changed. So I committed those updated files. (Theory: I was out of date and all of you are up to date.)

Please rebase and try building Storybook again :)

[severinbeauvais]

Successfully published:
 - @bcrs-shared-components/action-chip@1.0.29
 - @bcrs-shared-components/breadcrumb@2.0.7
 - @bcrs-shared-components/business-lookup@1.0.5
 - @bcrs-shared-components/certify@2.0.10
 - @bcrs-shared-components/completing-party@2.0.9
 - @bcrs-shared-components/contact-info@1.1.11
 - @bcrs-shared-components/court-order-poa@2.0.11
 - @bcrs-shared-components/date-picker@1.1.21
 - @bcrs-shared-components/effective-date-time@1.0.19
 - @bcrs-shared-components/fee-summary@1.1.24
 - @bcrs-shared-components/folio-number-input@1.0.24
 - @bcrs-shared-components/nature-of-business@1.0.13
 - @bcrs-shared-components/share-structure@2.0.4
 - @bcrs-shared-components/staff-comments@1.2.8
 - @bcrs-shared-components/staff-payment@2.0.13
 - @bcrs-shared-components/enums@1.0.22
 - @bcrs-shared-components/interfaces@1.0.42
lerna success published 17 packages

[severinbeauvais]

I'm not sure why all the components were up-versioned but I'm confident there was no change to them so 🤷

(In the past, this kind of thing happened when there was a mismatch between the tags in GH and locally, but I don't think that's the case here. Anyway, no harm done.)

[lambert-alex]

That is strange, I

I'm not sure why all the components were up-versioned but I'm confident there was no change to them so 🤷

(In the past, this kind of thing happened when there was a mismatch between the tags in GH and locally, but I don't think that's the case here. Anyway, no harm done.)

I'll try and scrap my fork and start with a fresh clone next time I work here so I don't run into this issue again hopefully.

[severinbeauvais]

I'll try and scrap my fork and start with a fresh clone next time I work here so I don't run into this issue again hopefully.

Might be on my side. I dunno and I'm not worried about it. (But cloning the repo is easy so not a bad idea.)