14797 relationships panel

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

14797 relationships panel #160

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: bcgov/entity#14797

Description of changes:

Created Relationships Panel

Default: default

If no relationship is selected: none selected

The component has one prop and two emitters:
- Prop: Draft relationships array
- 1st emitter: Selected relationships (Array)
- 2nd emitter: Check and validate if at least one relationship is selected (Boolean)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 1 year ago

If no relationship is selected:

Do you show error message text if no relationships are selected?

JazzarKarim commented 1 year ago

If no relationship is selected:

Do you show error message text if no relationships are selected?

I spoke with Ethan about the design. As per the UXPin, no text is going to be shown. Instead, the tooltip text and the relationships will be marked as red (error) as follows:

uxpin

JazzarKarim commented 1 year ago

Good work @JazzarKarim

Thanks Jonathan! 🙏

JazzarKarim commented 1 year ago

Looks good!

Glad to hear that. Thanks so much Sev! 😃