search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

16306 - Get rid of array.prototype.move + add in CI and fix unit tests #181

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

Update various package + package-locks, small unit test update.

Issue #: /bcgov/entity#16306

Description of changes: Get rid of array.prototype.move. This prototype isn't allowed by the more recent versions of pdfjs-dist.

https://github.com/mozilla/pdfjs-dist/blob/5f07d5a4159bb99eee2f6143d1297f03b45bba58/lib/core/worker.js#L95

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

seeker25 commented 1 year ago

I've included the library in the code, plus fixed some other unit tests. Works locally, not sure if it will work on github actions.

seeker25 commented 1 year ago

@severinbeauvais could you take a look at this before merging again? I made a bunch of other changes

severinbeauvais commented 1 year ago

@severinbeauvais could you take a look at this before merging again? I made a bunch of other changes

  1. I'm OK with the changes except the imports of the local mixins (if there's any way we can fix that...)

  2. Are there are workflow changes that require an update to the README file?

seeker25 commented 1 year ago
  1. Reverted it back
  2. No changes required right now - it's just CI
seeker25 commented 1 year ago

I'm out of time working on this - someone else can fix the CI unit test.

It passes locally, but due to that console error - it causes the unit test to fail on the CI.