search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

16781 - Migrate Base Address from sbc-common-components #185

Closed TMunro7 closed 1 year ago

TMunro7 commented 1 year ago

Issue #: /bcgov/entity#16781

Description of changes: Added the BaseAddress and SbcFeeSummary Components from SbcCommonComponents to BcrsCommonComponenets

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

seeker25 commented 1 year ago

Please change the title, so it includes the ticket number:

EG. 16781 - Migrate Base Address from sbc-common-components

Also the github linking isn't working because the issues didn't convert into a hyperlink

seeker25 commented 1 year ago

We'll need to tweak the existing components so they don't point to sbc-common-components and point to this component instead.

seeker25 commented 1 year ago

Minor lint fix to go

severinbeauvais commented 1 year ago

I recommend a separate PR for the Storybook files, so that I don't have to see ~106~ 113 extra files in the diff :)

seeker25 commented 1 year ago

mmend a separate PR for the Storybook files, so that I don't have to see ~106~ 113 extra files in the diff :)

Yup, came back after one of Tay's commits. I force pushed yesterday to get rid of these - Should have reverted instead

image

severinbeauvais commented 1 year ago

Please rebase and resolve the merge conflict.

severinbeauvais commented 1 year ago

Just a couple of small fixes and then lmk when to merge and publish this.