17137 Updated misc Corp Type Codes

[severinbeauvais]

Issue #: bcgov/entity#17137

Description of changes:

• deleted obsolete NrRequestTypeCodes values
• updated some comments
• renamed CorpTypeCd.BC_CORPORATION -> CorpTypeCd.CORPORATION
• renamed CorpTypeCd.NR_SOLE_PROP -> CorpTypeCd.SOLE_PROPRIETORSHIP
• added CorpTypeCd.XPRO_LIMITED_LIABILITY_COMPANY
• added CorpTypeCd.SOCIETY_NR
• renamed CorpTypeCd.BC_UNLIMITED -> CorpTypeCd.UNLIMITED_LIABILITY_COMPANY
• added CorpTypeCd.XPRO_LIMITED_LIABILITY_PARTNERSHIP
• added CorpTypeCd.XPRO_LIMITED_PARTNERSHIP
• added CorpTypeCd.XPRO_SOCIETY_NR
• added CorpTypeCd.XPRO_UNLIMITED_LIABILITY_COMPANY

Ref: request_types.pdf

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[severinbeauvais]

As far as I can tell, the 3 enums that I renamed aren't used in any of our UIs (except the feature branch for Namerequest UI, where I will update it shortly).

This change will allow me to get rid of the "Other" enum in Namerequest UI and map EntityType entirely to CorpTypeCd. Ref: https://github.com/bcgov/namerequest/pull/622#issuecomment-1624201058

[severinbeauvais]

The EditShareStructure failing unit tests above pre-existed this PR. There is ticket 16965 to fix them later.