search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

Add in .nojekyll file. This should allow assets with _ to be published. #193

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

https://github.com/storybookjs/storybook/issues/21771

" if you are publishing pages from docs folder, the .nojekyll file should be put under docs"

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 1 year ago

I noticed that npm run build-storybook deletes this .nojekyll file. It must clear its output folder (docs/) when it rebuilds.

For now I'm working around this by not committing the deletion of the subject file after a Storybook rebuild.

NotJustClarkKent commented 8 months ago

@severinbeauvais this was our issue! We added the file but the build pipeline was deleting it - thanks for the tip!!