bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

17124 + 16550 - Vue3 upgrade: Upgrade a component + Storybook #204

Closed ketaki-deodhar closed 10 months ago

ketaki-deodhar commented 11 months ago

Issue #: /bcgov/entity#17124 and /bcgov/entity#16550

Description of changes:

After upgrade -

https://github.com/bcgov/bcrs-shared-components/assets/116035339/78c8bd06-af03-4a2d-9382-26689d184128

DEV link for comparison - https://bcgov.github.io/bcrs-shared-components/

Notes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 11 months ago

Amazing work, Ketaki! Just a few questions above.

ketaki-deodhar commented 11 months ago

Amazing work, Ketaki! Just a few questions above.

I will look at all the amazing suggestions and questions today