search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

18526 - import Date picker components #212

Closed ketaki-deodhar closed 10 months ago

ketaki-deodhar commented 10 months ago

Issue #: /bcgov/entity#18526

Description of changes:

BaseDatePicker:

image

InputFieldDatePicker:

https://github.com/bcgov/bcrs-shared-components/assets/116035339/4a3e7e66-fe45-4164-993e-baa38774ce04

RangeDatePicker:

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

ketaki-deodhar commented 10 months ago

Check with Cam on whether he has any date component unit tests you could add here.

I checked with Cameron and unfortunately they do not have any unit tests. Does it make sense to create a new ticket for building unit tests?

Yes (even if we never get around to it).

Do we have unit tests for the Vue2 DatePicker, and will they work (since the functionality is supposed to be the same)?

Don't get bogged down on this.