18752 base-address upgrade

[PaulGarewal]

Issue #: /bcgov/entity#18752

Description of changes:

• Added new vue3 base address from Assets Team.
• Testing still needed to be completed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[PaulGarewal]

Not sure if this is what we are looking for (but it is a start):

[severinbeauvais]

You will know you have succeeded when this component can be used externally and works properly there. Hopefully it can be used in the same way as the old component. You may need to create a very simple Vue3 UI to test this.

[ketaki-deodhar]

Not sure if this is what we are looking for (but it is a start):

This is a good start. Street address and street additional fields should be displayed as well.

[severinbeauvais]

Not sure if this is what we are looking for (but it is a start):

So there's no labels on the fields? Ask UI if we can use it like this (which is presumably the same as in the Assets/PPR UI).

[PaulGarewal]

Not sure if this is what we are looking for (but it is a start):

So there's no labels on the fields? Ask UI if we can use it like this (which is presumably the same as in the Assets/PPR UI).

Ok will do. I will ask Yui.

Here is what the fields look like before entering any values (for reference):

[PaulGarewal]

Not sure if this is what we are looking for (but it is a start):

So there's no labels on the fields? Ask UI if we can use it like this (which is presumably the same as in the Assets/PPR UI).

Ok will do. I will ask Yui.

Here is what the fields look like before entering any values (for reference):

Confirmed with Yui that we want the same setup as the Assets Team for the BaseAddress.

[severinbeauvais]

Confirmed with Yui that we want the same setup as the Assets Team for the BaseAddress.

Nice! I hoped this would be the case but now it's official.

[severinbeauvais]

You will know you have succeeded when this component can be used externally and works properly there. Hopefully it can be used in the same way as the old component. You may need to create a very simple Vue3 UI to test this.

Any change this will work in a Vue2 UI?

Can you do an address lookup in Storybook? (I know it needs an API key, and we won't want to put that key in any commit in GH as our repos are public!)

Are the props and events the same as the old address component?

[cameron-eyds]

@severinbeauvais @PaulGarewal If your keen on testing in a Vue3 instance before committing, feel free to pull our feature branch: https://github.com/bcgov/ppr/tree/Vue3-Upgrade-Feature-Branch

It's pretty stable, for the most part :) Hit me up for an .env if you want to run it. OR if you want to commit and give it a go as a true import, the above holds true as well 👍

[JazzarKarim]

Due to Paul's computer issues, last commit is from my laptop.