search

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

17086 update shareStructure.vue #216

Closed tshyun24 closed 10 months ago

tshyun24 commented 10 months ago

Issue #: /bcgov/entity#17086

Description of changes: update v-data-table to have the shareStructure.vue have the same data table as before, but "correct" and "change" button in the table does not work, because it calls another editShareStructure.vue file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

tshyun24 commented 10 months ago

image looks like that right now

tshyun24 commented 10 months ago

I know ~yout~ your ticket was to handle the v-data-table only, but while you're here, does this Share Structure component work properly under Vue3? If not, what else needs to be updated?

Yeah, so for now, the dropdown bar works for move up and move down. But add series will request the update at EditShareStructure.vue, and 'remove' need some modifications at https://github.com/bcgov/bcrs-shared-components/blob/6ac54d98102ec0a8d91beabccf33716d724d2998/src/components/share-structure/ShareStructure.vue#L1007

image.

And also Change or Correct button and Add Share Class button does not work, also request the update at EditShareStructure.vue. image

severinbeauvais commented 10 months ago

Shaoyun, please create a new ticket (in the same epic) to do the remaining work you identified above to get this component completely functional in Vue 3. Please post the new ticket number here. Thanks!

tshyun24 commented 10 months ago

Shaoyun, please create a new ticket (in the same epic) to do the remaining work you identified above to get this component completely functional in Vue 3. Please post the new ticket number here. Thanks!

Hiii Sev, should it be on the new Zenhub board or the one that we are using now?

severinbeauvais commented 10 months ago

Hiii Sev, should it be on the new Zenhub board or the one that we are using now?

We're still using the old board.

tshyun24 commented 10 months ago

New ticket for the remaining stuff: https://app.zenhub.com/workspaces/entities-team-space-6143567664fb320019b81f39/issues/gh/bcgov/entity/18939