Closed leodube-aot closed 10 months ago
leodube-aot
commented
10 months ago This is to help complete bcgov/entity#18722. I created a ticket to replace the duplicate component in Namerequest, and to add unit tests and finish up the storybook for this component:
leodube-aot
commented
10 months ago Does this require another storybook build before merge?
Edit: merging, if needed I'll create a new PR
severinbeauvais
commented
10 months ago Does this require another storybook build before merge?
In main branch, yes, because the SB build files are used for https://bcgov.github.io/bcrs-shared-components/.
In this feature branch, the SB files aren't used, except locally for your testing.
When we merge this feature branch into main (or rename it), then one of us will have to do a SB build and commit those files.
leodube-aot
commented
10 months ago In
mainbranch, yes, because the SB build files are used for https://bcgov.github.io/bcrs-shared-components/.In this feature branch, the SB files aren't used, except locally for your testing.
This was merged into main branch since it is not a Vue 3 component (it was mainly just copy pasted Vue 2 code from Namerequest). Should it have been to the feature branch? Or should I create a SB PR?
severinbeauvais
commented
10 months ago This was merged into main branch since it is not a Vue 3 component (it was mainly just copy pasted Vue 2 code from Namerequest). Should it have been to the feature branch? Or should I create a SB PR?
Hahaha, I am reviewing too many PRs at once!
Yes, this was correctly merged into main (Vue2) branch.
Yes, Storybook should be rebuilt and committed. Let me publish the changes in THIS PR first, and then you can rebase and create a new one for SB.
severinbeauvais
commented
10 months ago Yes, Storybook should be rebuilt and committed. Let me publish the changes in THIS PR first, and then you can rebase and create a new one for SB.
I have a better idea -- since I'm committing to the main branch anyway, I'll rebuild Storybook along the way.
severinbeauvais
commented
10 months ago I have a better idea -- since I'm committing to the main branch anyway, I'll rebuild Storybook along the way.
lerna notice
Successfully published:
- @bcrs-shared-components/action-chip@1.1.37
- @bcrs-shared-components/approval-type@1.0.43
- @bcrs-shared-components/base-address@2.0.13
- @bcrs-shared-components/breadcrumb@2.1.37
- @bcrs-shared-components/business-lookup@1.2.6
- @bcrs-shared-components/certify@2.1.37
- @bcrs-shared-components/completing-party@2.1.40
- @bcrs-shared-components/contact-info@1.2.37
- @bcrs-shared-components/correct-name@1.0.31
- @bcrs-shared-components/court-order-poa@3.0.33
- @bcrs-shared-components/date-picker@1.2.40
- @bcrs-shared-components/effective-date-time@1.1.40
- @bcrs-shared-components/enums@1.1.3
- @bcrs-shared-components/fee-summary@2.0.11
- @bcrs-shared-components/folio-number-input@1.1.37
- @bcrs-shared-components/interfaces@1.1.3
- @bcrs-shared-components/jurisdiction@1.0.0
- @bcrs-shared-components/limited-restoration-panel@2.0.21
- @bcrs-shared-components/mixins@1.1.31
- @bcrs-shared-components/nature-of-business@1.2.36
- @bcrs-shared-components/relationships-panel@1.0.31
- @bcrs-shared-components/services@1.0.12
- @bcrs-shared-components/share-structure@2.2.14
- @bcrs-shared-components/staff-comments@1.3.38
- @bcrs-shared-components/staff-payment@2.1.37
lerna success published 25 packagesThere are many updated packages because they depended on shared enums.
severinbeauvais
commented
10 months ago
Issue #: /bcgov/entity#18722
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).