18999 - Vue 3 upgrade: StaffPayment, FolioNumberInput, SubMenu

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

18999 - Vue 3 upgrade: StaffPayment, FolioNumberInput, SubMenu #231

Closed leodube-aot closed 8 months ago

leodube-aot commented 9 months ago

Issue #: /bcgov/entity#18999

Description of changes:

Updated StaffPayment component to Vue 3
Updated FolioNumberInput since it is used in the StaffPayment component
Updated SubMenu since storybook (for some reason) kept showing errors from that component in the StaffPayment component storybook.

Note: I am off until Jan 15

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

ketaki-deodhar commented 9 months ago

Please add color="primary" to v-radio so that the color is changed to blue after selection. I had the same issue in LimitedRestorationPanel upgrade :)

DEV:

LOCAL:

severinbeauvais commented 8 months ago

Please rebase.

Is it all working properly now?

leodube-aot commented 8 months ago

@severinbeauvais Yes all 3 components seem to be working fine now

leodube-aot commented 8 months ago

I think the main takeaway here is that during the conversion of the v-model prop and event default names from:

:value="someVariable" -> :modelValue="someVariable"
@input="someFunction($event)" -> @update:modelValue="someFunction($event)"

if the updates to the modelValue prop are not working correctly, then updating the event to:

@input="someFunction($event)" -> @update:someVariable="someFunction($event)"

is the solution.