18997: Vue 3 Upgrade - Completing Party

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

18997: Vue 3 Upgrade - Completing Party #232

Closed PaulGarewal closed 8 months ago

PaulGarewal commented 9 months ago

Issue #: /bcgov/entity#18997

Description of changes:

Upgrade the Completing Party Shared Component to Vue3
Used the Base-Address Vue 3 component upgrade as a template; excessive imports here that may need to be cut to reduce the bloat.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

PaulGarewal commented 9 months ago

Current output in Storybook:

From the Vue 2 version (below) I am unable to currently display the address:

May be due to the excessive Address files and importing the AddressIF incorrectly.

Currently working on this and reducing some bloat in the supporting files.

severinbeauvais commented 9 months ago

Re:

~If you can't resolve this with a rebase, just revert the files and remind me to do a lerna bootstrap --hoist when I next publish these components.~ Karim did it 👍

JazzarKarim commented 8 months ago

As I need work today and Paul is focusing on his legal api outputs ticket https://github.com/bcgov/entity/issues/18802 (which is more important due to our objective 3), I'll be picking up from where Paul left off here.

severinbeauvais commented 8 months ago

By the way, lerna bootstrap --hoist is deprecated in the latest version of Lerna. One of us will have to research what the new way to update component dependencies is.

severinbeauvais commented 8 months ago

Karim, please verify and close off the other conversations. Nice work so far!

JazzarKarim commented 8 months ago

Karim, please verify and close off the other conversations. Nice work so far!

Thanks! I verified all conversations. Please let me know if there are any other comments or if I can proceed with merging.