20989 - Add USA states to jurisdiction list

bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.

https://bcgov.github.io/bcrs-shared-components/

Apache License 2.0

3 stars 30 forks source link

20989 - Add USA states to jurisdiction list #253

Closed ketaki-deodhar closed 5 months ago

ketaki-deodhar commented 5 months ago

Issue #: /bcgov/entity#20989

Description of changes:

Add USA states to jurisdiction list
Add a flag to show USA jurisdictions conditionally

Flag defaults to flase (Current implementation for NR and Amalgamation)

Flag set to True (lists USA states)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 5 months ago

While publishing, I bumped up the minor version since this is more than a patch.

ketaki-deodhar commented 5 months ago

While publishing, I bumped up the minor version since this is more than a patch.

Thanks Sev!

severinbeauvais commented 5 months ago

So... US is in group 2 even when the prop is True.

severinbeauvais commented 5 months ago

@ketaki-deodhar , you were on the right track with duplicates -- the list doesn't support duplicate text items, but "United States" was in there first as a group and then as an item.

I consider this a bug. It can be demonstrated by changing the text (label) of the group, ie,

Please add a filter to remove US from the international list when the prop is True. (For cleanliness, I suggest creating a nested function and passing it to the filter call.)