bcgov / bcrs-shared-components

BCRS Shared Components is a multi-package Lerna repository of shared Vue components, each published individually and that you can explore/ develop/ document/ test using Storybook.
https://bcgov.github.io/bcrs-shared-components/
Apache License 2.0
3 stars 30 forks source link

updated storybook and lerna + created DetailComponent component #5

Closed vysakh-menon-aot closed 4 years ago

vysakh-menon-aot commented 4 years ago

Issue #: /bcgov/entity#4812

Description of changes:

Notes:

Created npm organization https://www.npmjs.com/settings/bcrs-shared-components/packages, all packages will be published here.

To consume the npm package execute npm i @bcrs-shared-components/detail-comment in other app's

Note: This app can still be refined before using it.

Examples of Storybook are contained in "src/stories" folder.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 4 years ago

Lekshmi mentioned to me that the dist folder in each component doesn't need to be checked in (since it's not published to npm, right?)

Also the xxx.stories.ts files don't serve any purpose in npm, so they can be ignored too.

Can you see about updating the git ignore file accordingly please?

vysakh-menon-aot commented 4 years ago

Lekshmi mentioned to me that the dist folder in each component doesn't need to be checked in (since it's not published to npm, right?)

Also the xxx.stories.ts files don't serve any purpose in npm, so they can be ignored too.

Can you see about updating the git ignore file accordingly please?

I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.

severinbeauvais commented 4 years ago

I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.

Would updating https://github.com/bcgov/bcrs-shared-components/blob/master/.gitignore work?

vysakh-menon-aot commented 4 years ago

I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.

Would updating https://github.com/bcgov/bcrs-shared-components/blob/master/.gitignore work?

We need *.stories.ts in git, so i dont think its valid