Closed vysakh-menon-aot closed 4 years ago
Lekshmi mentioned to me that the dist folder in each component doesn't need to be checked in (since it's not published to npm, right?)
Also the xxx.stories.ts files don't serve any purpose in npm, so they can be ignored too.
Can you see about updating the git ignore file accordingly please?
Lekshmi mentioned to me that the dist folder in each component doesn't need to be checked in (since it's not published to npm, right?)
Also the xxx.stories.ts files don't serve any purpose in npm, so they can be ignored too.
Can you see about updating the git ignore file accordingly please?
I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.
I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.
Would updating https://github.com/bcgov/bcrs-shared-components/blob/master/.gitignore work?
I tried npm ignore file to ignore stories.ts, unfortunately it didn't work. What we could do though is to keep stories.ts in separate folder like we do for test.
Would updating https://github.com/bcgov/bcrs-shared-components/blob/master/.gitignore work?
We need *.stories.ts in git, so i dont think its valid
Issue #: /bcgov/entity#4812
Description of changes:
Notes:
Created npm organization https://www.npmjs.com/settings/bcrs-shared-components/packages, all packages will be published here.
npm login
lerna version
-> change version, this will update version in package.json and commit those changes.lerna publish from-package
to explicitly publish packages where the latest version is not present in the registry. Yet to figure outlerna publish from-git
, good for automation.To consume the npm package execute
npm i @bcrs-shared-components/detail-comment
in other app'sNote: This app can still be refined before using it.
Examples of Storybook are contained in "src/stories" folder.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).