bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 13 forks source link

Bugfix/fix mismatched annotation #227

Closed calchoo closed 3 years ago

calchoo commented 3 years ago

Seems like when Annotation() is created, the breakpoint positions got swapped (due to sorting of positions) but the transcripts didn't, so the breakpoint positions and transcripts don't line up anymore. Fix is to check if breakpoints are in the right order, and swap them before Annotation() is created.

codecov[bot] commented 3 years ago

Codecov Report

Merging #227 into develop will increase coverage by 10.71%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #227       +/-   ##
============================================
+ Coverage    80.48%   91.20%   +10.71%     
============================================
  Files           52       52               
  Lines         9123     9126        +3     
============================================
+ Hits          7343     8323      +980     
+ Misses        1780      803      -977     
Flag Coverage Δ
#unittests 91.20% <100.00%> (+10.71%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mavis/annotate/file_io.py 88.73% <ø> (+2.25%) :arrow_up:
mavis/annotate/fusion.py 96.02% <ø> (+0.33%) :arrow_up:
mavis/annotate/genomic.py 93.12% <ø> (+1.03%) :arrow_up:
mavis/annotate/protein.py 91.28% <ø> (+5.12%) :arrow_up:
mavis/assemble.py 95.60% <ø> (+2.93%) :arrow_up:
mavis/blat.py 90.27% <ø> (+1.85%) :arrow_up:
mavis/breakpoint.py 95.00% <ø> (+1.53%) :arrow_up:
mavis/illustrate/elements.py 96.37% <ø> (+1.69%) :arrow_up:
mavis/interval.py 94.48% <ø> (ø)
mavis/annotate/variant.py 92.80% <100.00%> (+12.71%) :arrow_up:
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 13adb6c...5ed2628. Read the comment docs.