search

bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 13 forks source link

#254 fix nan values confusing downstream None checks #255

Closed calchoo closed 2 years ago

calchoo commented 2 years ago

Small bugfix to convert the default pandas nan to None values so the is None checks work later on.

codecov[bot] commented 2 years ago

Codecov Report

Merging #255 (dd01854) into develop_v3 (027c403) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop_v3     #255   +/-   ##
===========================================
  Coverage       86.66%   86.66%           
===========================================
  Files              53       53           
  Lines            8842     8843    +1     
  Branches         2234     2234           
===========================================
+ Hits             7663     7664    +1     
  Misses            719      719           
  Partials          460      460
Flag Coverage Δ
unittests 86.66% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/util.py 80.25% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e3b1d98...dd01854. Read the comment docs.