bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 14 forks source link

Feature/more type annotations #303

Closed creisle closed 2 years ago

creisle commented 2 years ago

No rush on this one, just adding more types to make static checking/autocomplete better and hopefully improve readability

Improvements

codecov[bot] commented 2 years ago

Codecov Report

Merging #303 (256794c) into develop_v3 (841c364) will decrease coverage by 0.13%. The diff coverage is 79.03%.

Impacted file tree graph

@@              Coverage Diff               @@
##           develop_v3     #303      +/-   ##
==============================================
- Coverage       87.12%   86.98%   -0.14%     
==============================================
  Files              53       53              
  Lines            8831     8854      +23     
  Branches         2291     2297       +6     
==============================================
+ Hits             7694     7702       +8     
- Misses            691      699       +8     
- Partials          446      453       +7     
Flag Coverage Δ
unittests 86.98% <79.03%> (-0.14%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mavis/annotate/genomic.py 88.09% <ø> (ø)
src/mavis/annotate/main.py 90.47% <ø> (ø)
src/mavis/blat.py 85.45% <ø> (ø)
src/mavis/cluster/cluster.py 89.47% <ø> (ø)
src/mavis/align.py 84.81% <33.33%> (-0.55%) :arrow_down:
src/mavis/bam/stats.py 85.71% <50.00%> (-0.96%) :arrow_down:
src/mavis/types.py 71.42% <60.00%> (-28.58%) :arrow_down:
src/mavis/util.py 78.09% <66.66%> (-0.56%) :arrow_down:
src/mavis/illustrate/elements.py 93.09% <70.00%> (-0.64%) :arrow_down:
src/mavis/annotate/fusion.py 91.23% <71.42%> (-0.52%) :arrow_down:
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8283caf...256794c. Read the comment docs.