codecov[bot]
commented
2 years ago Codecov Report
Merging #333 (38d07c4) into develop_v3 (8b59a51) will increase coverage by
0.04%. The diff coverage is100.00%.
@@ Coverage Diff @@
## develop_v3 #333 +/- ##
==============================================
+ Coverage 86.48% 86.53% +0.04%
==============================================
Files 57 57
Lines 9341 9340 -1
Branches 2407 2407
==============================================
+ Hits 8079 8082 +3
+ Misses 779 775 -4
Partials 483 483 | Flag | Coverage Δ | |
|---|---|---|
| unittests | 86.53% <100.00%> (+0.04%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/mavis/validate/call.py | 87.93% <ø> (+0.76%) |
:arrow_up: |
| src/mavis/validate/evidence.py | 93.96% <ø> (ø) |
|
| src/mavis/bam/read.py | 91.98% <100.00%> (ø) |
|
| src/mavis/validate/align.py | 84.76% <100.00%> (-0.05%) |
:arrow_down: |
| src/mavis/validate/gather.py | 83.88% <100.00%> (ø) |
|
| src/mavis/breakpoint.py | 90.58% <0.00%> (-0.65%) |
:arrow_down: |
| src/mavis/validate/base.py | 78.84% <0.00%> (+0.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 9969b28...38d07c4. Read the comment docs.
The purpose of this PR is to change our Read mock so that we are always using sensible/possible reads in our tests. The previous mock let you avoid things like cigar string and set things like reference_end directly which ended up with some strange behaviour and meant some of our tests were throwing the error we expected for the wrong reason.
The new Mock is a little bit more a pain to use b/c you can't skip fields but ensures our tests are always testing what we intend them to
It also is more readable and shorter since it uses the cigar string instead of the cigartuples as input