bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 13 forks source link

Unused variables in validation module #334

Open zhemingfan opened 1 year ago

zhemingfan commented 1 year ago

Certain parts of the validate module contains redundant code: For example - count: https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L417

Align_options for BWA-MEM, which doesn't use any additional align parameter. https://github.com/bcgsc/mavis/blob/develop_v3/src/mavis/validate/align.py#L464

These should be removed or better documented.

mattdoug604 commented 1 year ago

Hi @zhemingfan,

Just to clarify, did you encounter an error here or is this something you noticed could be be improved upon?

zhemingfan commented 1 year ago

For now, it's just enhancements.