bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 13 forks source link

Bugfix to Summary module clustering output #337

Closed zhemingfan closed 1 year ago

zhemingfan commented 1 year ago

Bugfix in this module is targeted for two issues:

  1. Currently, no structural variants are merged in Summary if the sorted test file (mock_dgv_annotations.txt) is provided given an exact coordinate of the variant dgv1n82. This occurs because we calculate dist = Interval((dgv_region.start), bpp.break1). Given the first entry to be 1 1 2300000 nsv482937 and a BPP with a breakpoint1 of 10001. This dist will almost always be larger than the lowest_resolution + distance, resulting in breaking out of the loop for a particular chr, missing out on any downstream SVs on the same chr.

  2. Multiple SV matches on one call are being overwritten.

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.53% // Head: 86.67% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (8b932a6) compared to base (38d07c4). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop_v3 #337 +/- ## ============================================== + Coverage 86.53% 86.67% +0.14% ============================================== Files 57 57 Lines 9340 9342 +2 Branches 2407 2342 -65 ============================================== + Hits 8082 8097 +15 + Misses 775 763 -12 + Partials 483 482 -1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `86.67% <100.00%> (+0.14%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/bcgsc/mavis/pull/337?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [src/mavis/summary/summary.py](https://codecov.io/gh/bcgsc/mavis/pull/337/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3N1bW1hcnkvc3VtbWFyeS5weQ==) | `64.58% <100.00%> (+9.65%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.