bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 14 forks source link

Improvement/add arriba test #346

Closed calchoo closed 1 year ago

calchoo commented 1 year ago

Re adding arriba tests that were failing before

codecov[bot] commented 1 year ago

Codecov Report

Base: 86.92% // Head: 86.92% // No change to project coverage :thumbsup:

Coverage data is based on head (678323e) compared to base (7825b3c). Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop_v3 #346 +/- ## =========================================== Coverage 86.92% 86.92% =========================================== Files 57 57 Lines 9390 9390 Branches 2355 2355 =========================================== Hits 8162 8162 Misses 752 752 Partials 476 476 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `86.92% <50.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [src/mavis/annotate/file\_io.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL2Fubm90YXRlL2ZpbGVfaW8ucHk=) | `77.06% <ø> (ø)` | | | [src/mavis/annotate/variant.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL2Fubm90YXRlL3ZhcmlhbnQucHk=) | `88.72% <ø> (ø)` | | | [src/mavis/convert/\_\_init\_\_.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL2NvbnZlcnQvX19pbml0X18ucHk=) | `87.76% <ø> (ø)` | | | [src/mavis/convert/vcf.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL2NvbnZlcnQvdmNmLnB5) | `94.11% <ø> (ø)` | | | [src/mavis/illustrate/util.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL2lsbHVzdHJhdGUvdXRpbC5weQ==) | `84.65% <ø> (ø)` | | | [src/mavis/pairing/pairing.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3BhaXJpbmcvcGFpcmluZy5weQ==) | `89.86% <0.00%> (ø)` | | | [src/mavis/summary/summary.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3N1bW1hcnkvc3VtbWFyeS5weQ==) | `70.00% <ø> (ø)` | | | [src/mavis/validate/assemble.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3ZhbGlkYXRlL2Fzc2VtYmxlLnB5) | `90.28% <ø> (ø)` | | | [src/mavis/validate/gather.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3ZhbGlkYXRlL2dhdGhlci5weQ==) | `83.88% <ø> (ø)` | | | [src/mavis/util.py](https://codecov.io/gh/bcgsc/mavis/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3V0aWwucHk=) | `80.07% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dustinbleile commented 1 year ago

looks like a codecov issue with the check?

calchoo commented 1 year ago

looks like a codecov issue with the check?

I'm pretty sure we can ignore that check since the only failing change to that file was for linting