bcgsc / mavis

Merging, Annotation, Validation, and Illustration of Structural variants
http://mavis.bcgsc.ca
GNU General Public License v3.0
72 stars 13 forks source link

#355 fix chromosome comparison check #356

Closed calchoo closed 10 months ago

calchoo commented 10 months ago

Fix to get the chromosomes with a "chr" and without a "chr" to compare properly when aligning reads

codecov[bot] commented 10 months ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (d7e7c01) 86.92% compared to head (3bbe219) 86.90%. Report is 1 commits behind head on develop_v3.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop_v3 #356 +/- ## ============================================== - Coverage 86.92% 86.90% -0.03% ============================================== Files 57 57 Lines 9392 9392 Branches 2356 2356 ============================================== - Hits 8164 8162 -2 - Misses 753 754 +1 - Partials 475 476 +1 ``` | [Flag](https://app.codecov.io/gh/bcgsc/mavis/pull/356/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/bcgsc/mavis/pull/356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | `86.90% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/bcgsc/mavis/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc) | Coverage Δ | | |---|---|---| | [src/mavis/validate/align.py](https://app.codecov.io/gh/bcgsc/mavis/pull/356?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc#diff-c3JjL21hdmlzL3ZhbGlkYXRlL2FsaWduLnB5) | `85.30% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/bcgsc/mavis/pull/356/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgsc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.