bdring / Grbl_Esp32

A port of Grbl CNC Firmware for ESP32
GNU General Public License v3.0
1.68k stars 528 forks source link

RC Servo always disabled when Stepper/EnableInvert is ON #977

Open gautamjain opened 2 years ago

gautamjain commented 2 years ago

Firmware Version: 1.3a Date 20210816

Repeatable? Yes

Conditions:

Bug: RC servo is always disabled (there is no PWM signal generated). I think this is happening because Stepper/EnableInvert is a global flag and is being applied to all motors/axis. If using Trinamic drivers, the enable inversion works as expected. But if you also have an RC servo, then the inversion causes it to get disabled - which should not happen.

https://github.com/bdring/Grbl_Esp32/blob/5316c64abb4d2de994799c09621c777391cd2386/Grbl_Esp32/src/Motors/Motors.cpp#L425-L437

bdring commented 2 years ago

I'll look at that when I get a chance.