Closed bearecinos closed 1 year ago
Ok I did some changes to the script ... and improved the issue text... now the issue above reflects what we want to do ... I will wait for @jrmaddison input before testing this.. as I'm not sure if I'm replacing alpha and beta correctly...
I thought of fixing issue #32 while I have this PR open...
Thanks a lot @jrmaddison for the review !! ... I will work more on this script as it was done very fast and needs improving.. I shall commit the changes soon
@jrmaddison @dngoldberg
Dan suggested to modify the linearity test so we do a small perturbation on alpha and beta. He suggested to re-run the forward stage using a new alpha and beta... so we keep the dot product as:
and compute a new VAF trajectory using
Q = slvr.timestep(adjoint_flag=1, qoi_func=qoi_func)
Where the Q will come fromAnd we will be plotting this new $Q^{vaf}_{new}$
instead of
The red dotted line in this plot
For that we don't need to calculate sensitivities or run the adjoint... just do
slvr.timestep
and replace $\alpha$ and $\beta$ model objects with the new ones.I think this is what I've done in run_linearity_fwd.py#L79-L93 Let me know if that script is correct or I need to change something. I'm not sure if I need to do
function_update_state()
? to replace the old alpha object with the new one?Thanks!