search

beatnaut / remaputils

Remap Utils
0 stars 1 forks source link

Update alerts.R #11

Closed andr31V closed 1 year ago

andr31V commented 1 year ago

Removed this data command that is outside of defined functions.

This may be on purpose and related to the new alertMissingResourceField function so feel free to reject it and close if so.

beatnaut commented 1 year ago

I am rejecting this PR, because:

  1. The deletion of the line in Update alerts.R is wrong. It should stay.

  2. The commentary inside the function brackets is confusing.

beatnaut commented 1 year ago

Looks fine to me. I can see the example working. Before you merge, please rebase and recommit. If all good, merge!