search

beatrice-casey / Flixster

A recreation of the Flixster app that shows movies that are in theatres.
0 stars 0 forks source link

Feedback #1

Open majia67 opened 4 years ago

majia67 commented 4 years ago

Hi Beatrice, I did a review of your code and it looks great in general! I have a few recommendations on the code styles:

  1. It's usually a good habit to mark class members private so they won't be accidentally accessed outside the class. If you're sure the variable reference won't change, marking it as final
  2. It's a good habit to add some javadocs at the top of the class so others can know what this class is for

I'll add additional comments here if I have any. Besides that it looks good and keep up the good work!

codepathreview commented 4 years ago

Nice work, Beatrice!

We hope you learned a lot this week with the Flixster app. This is a much more complex app than the initial Todo app as it includes a lot of new concepts. We really appreciate that you completed stretch Stories in addition to the required stories. This is a great way to get the most out of the class. The stretch goals provide a lot of really good learning opportunities.

We have provided a detailed Flixster Feedback Guide here: http://courses.codepath.org/snippets/android_university_fast_track/feedback_guides/project_2_feedback.md which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms, and RecyclerView, which is a superior stand-in for the ListView we used in the Todo project. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, and handling remote images.

If you have any particular questions about the assignment, feel free to reply here or or email us support@codepath.org.

/cc @codepathreview