search

ben-denham / labtech

Easily run experiment permutations with multi-processing and caching
https://ben-denham.github.io/labtech/
GNU General Public License v3.0
7 stars 1 forks source link

Add tests for `find_tasks_in_param` #12

Closed nathanjmcdougall closed 4 months ago

nathanjmcdougall commented 5 months ago

Add unit tests.

Some refactoring to have a one-source-of-truth for information about what scalars are supported in labtech tasks parameters.

nathanjmcdougall commented 5 months ago

Having type check issues, will take a look later

nathanjmcdougall commented 5 months ago

Okay, so tests are failing in 3.10 for the case of a frozendict; that frozendict is not actually a subtype of dict until 3.11. I'm guessing we should just explicitly handle this case in the function, but I want to check you you about that.

ben-denham commented 4 months ago

This branch is all good now, but needs a rebase on main to merge cleanly. I made the mistake of using GitHub's conflict resolution interface, but that's made an ugly merge commit on your branch sorry :(