search

benchopt / benchmark_tv_1d

TV Denoising in 1D
2 stars 7 forks source link

Simplify CondatVu #26

Closed EnLAI111 closed 2 years ago

EnLAI111 commented 2 years ago

I want to simplify the algorithm of CondatVu and that of ChambollePock. So I updated the file of CondatVu. As for ChambollePock, I just deleted it because ChambollePockPDsplit is actually its simplified version.

agramfort commented 2 years ago

@EnLAI111 it's better to avoid deleting files to make improvements as it's then much harder for us to review the diff and understand the "improvement".

EnLAI111 commented 2 years ago

Can we merge this one?