search

bene-ges / nemo_compatible

useful things that work with NVIDIA NeMo library
Apache License 2.0
9 stars 1 forks source link

Missing imports utils.py #11

Closed thomaschhh closed 8 months ago

thomaschhh commented 8 months ago

There are quite a few imports missing in https://github.com/bene-ges/nemo_compatible/blob/main/scripts/nlp/en_spellmapper/dataset_preparation/utils.py

/nemo_compatible/scripts/nlp/en_spellmapper/dataset_preparation/utils.py", line 26, in <module>
    def get_title_and_text_from_json(content: str, exclude_titles: Set[str]) -> Tuple[str, str, str]:
NameError: name 'Set' is not defined. Did you mean: 'set'?

I'll create a pull request.