search

bene-ges / nemo_compatible

useful things that work with NVIDIA NeMo library
Apache License 2.0
9 stars 1 forks source link

Training - NotImplementedError #15

Closed thomaschhh closed 10 months ago

thomaschhh commented 1 year ago

When running run_training.sh

I get the following error:

NotImplementedError: Support for validation_epoch_end has been removed in v2.0.0. SpellcheckingAsrCustomizationModel implements this method. You can use the on_validation_epoch_end hook instead. To access outputs, save them in-memory as instance attributes. You can find migration examples in https://github.com/Lightning-AI/lightning/pull/16520.

My pytorch-lightning version is 2.0.9. How did fix this on your side?

bene-ges commented 1 year ago

Thank you for this observation, I will try to fix it tomorrow

bene-ges commented 1 year ago

I created a PR in nemo, though it can take some time before they accept it. You can look at the changes and test them yourself

thomaschhh commented 1 year ago

This looks good, thank you.

Let's leave this open until they accept your PR.

bene-ges commented 11 months ago

@thomaschhh this PR was finally merged