search

benjaoming / rhythmbox-fullscreen

Display and control rhythmbox via full-screen
Other
8 stars 5 forks source link

In-situ resize of chosen track rather then refresh #2

Closed fossfreedom closed 11 years ago

fossfreedom commented 11 years ago

Clicking a track resets the track list back to the top - the complete refresh of the screen is a little jarring to the eye.

Is there a way to update just this track cell on the screen rather that doing a complete refresh?

benjaoming commented 11 years ago

Whenever playing state changes, the plugin is notified and does a complete update in order to remain in a consistent state. If there is a different signal notifying that the playlist has changed, we could use this to only reload the playlist on such event. I'll do this in case this signal exists.

fossfreedom commented 11 years ago

Not quite sure I follow - playing-source-changed is the signal if a playlist changes.

When choosing the track - you are choosing from tracks in the current playlist - thus "playing-song-changed" is appropriate - but shouldnt called reload-playlist. reload-playlist perhaps should be done if playing-source-changed is connected.

However - you are in fullscreen - when can the user actually change the playlist?

benjaoming commented 11 years ago

Alright, I wasn't with any docs or code when I wrote that, you're right, play-source-changed is the only signal to listen to for reloading the playlist, otherwise we can just change the index of current_track and rebuild the widget for the previous track playing and the new one.