bentley-historical-library / bhl_born_digital_utils

Scripts used for removable media transfers at the Bentley Historical Library
5 stars 8 forks source link

Allow creating DIPs based on bhl_inventory.csv in make_dips.py; Add four new QC scripts #8

Closed hyeeyoungkim closed 5 years ago

hyeeyoungkim commented 5 years ago

This pull request includes a major change (creating DIPs based on bhl_inventory.csv) to make_dips.py and four additional quality control scripts:

README.md has been updated to reflect the changes. The scripts have been tested with a large CD-based accession on Windows, Python 3.7.

eckardm commented 5 years ago

This is excellent, excellent work Hyeeyoung! The only thing I'd recommend for the future is more consistently descriptive commit messages and pull requests! E.g., instead of "updated readme" something like "added X, Y, Z to table of contents." You might also scope them to single updates or features.

That said, this is great work!

Thank you!