bentley-historical-library / bhl_born_digital_utils

Scripts used for removable media transfers at the Bentley Historical Library
5 stars 8 forks source link

Allow validating media files and deleting additional OS files #9

Closed hyeeyoungkim closed 5 years ago

hyeeyoungkim commented 5 years ago

This pull request includes:

README.md has been also updated to reflect the changes. The scripts have been tested with large CD-based accessions on Windows, Python 3.7.2.

djpillen commented 5 years ago

Just to make sure we're following standard conventions and that we don't run into any issues adding additional parameters in the future, would it be possible to make sure that all arguments follow the GNU Program Argument Syntax Conventions for the use of single/double hyphens for short (i.e., single character) and long options? Some of the arguments as they are currently formulated could be interpreted as multiple short options, e.g. -src could be read as equivalent to -s -r -c, -ds could be read as equivalent to -d -s, etc.

hyeeyoungkim commented 5 years ago

@djpillen Thanks for pointing out the parameter issue. I'll check the convention document and update the parameters.

hyeeyoungkim commented 5 years ago

@djpillen I updated argparse argument names for all scripts.

djpillen commented 5 years ago

Looks good, thanks!