can you add a lat/long location method?

ilyinss commented 1 year ago

Hello! in your code i find this one:

  # Latitude is dependent on location
  suppressMessages(
    capture.output(
      gocodeData <-  tibble(singlelineaddress = location) %>%
                     geocode(address=singlelineaddress,method = 'arcgis')
    )
  )

  lat <- gocodeData %>% .[["lat"]]
  # longitude for line3_text
  lon_map <-gocodeData %>%  .[["long"]]

its means that i need to put in your method address like string> That address you put in other function (geocode) and get lat/long on this.

its very simple, but not very flexible. i cant find lat long for some cities in Armenia (( its been very nice of you if you add this one to your library.

P.S. thank you for your library! With your library i want to create and print cards and congratulate our colleagaues with 8 march day ) when i'm print it - i take a foto and send you ))

In russian i may say it like this: Ребята, вы супер-крутые! Громадное спасибо вам за то, что вы написали. Это потрясающе и восхитительно!

thanks a lot!

benyamindsmith commented 1 year ago

@ilyinss I'm really happy that you're enjoying the package! Please do send me the picture when you print it!

As far as the address not being flexible, I found that if you are really specific with your location the result will be provided.

So for your case I would write <city>,<province>, Armenia and that should give you the result that you want.

Let me know if this is helpful!

ilyinss commented 1 year ago

Thx a lot. I’m tried to use string and understood: I can write at Cyrillic. It’s very good. But also, if I want to draw star map with precision address I must hand over geopair. Do you agree?

And (if I may tell about it), come ideas for library: 1/ more colors )) if it light colours (yellow, white, etc) you may draw stars with dark colours (reverse) 2/ more text fonts ) I think, users like to customise it and ggplot may give it to they 3/ More lines under star map. Now plot have 3 lines, isntit? Of course, I may use '\n’ line separator, but.. )))

In the end I wold like to say thank you one more time ) its very interesting library! Thanks a lot!

Sorry for my English, its not my native )

W/ best regards, Sergey

On 6 Mar 2023, at 04:04, Benjamin Smith @.***> wrote:

@ilyinss https://github.com/ilyinss I'm really happy that you're enjoying the package! Please do send me the picture when you print it!

As far as the address not being flexible, I found that if you are really specific with your location the result will be provided.

So for your case I would write ,, Armenia and that should give you the result that you want.

Let me know if this is helpful!

— Reply to this email directly, view it on GitHub https://github.com/benyamindsmith/starBliss/issues/12#issuecomment-1455279836, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPWDFBGS436MBHVMHBUGRTW2UZ2NANCNFSM6AAAAAAVQPY7HY. You are receiving this because you were mentioned.

benyamindsmith commented 1 year ago

@ilyinss I see.

Thats definitely a good idea. Maybe I should make a separate function which allows for a specific lon/lat coordinate to be specified.

As far as the other ideas are concerned:

1) More colors are definitely invited. If you have a specific set of colors in mind let me know and I can make them. Alternatively I could create a seperate function which allows for users to specify primary and secondary colors.

2) More text fonts are also a good idea. Maybe it could also be added in this new function.

3) There is no end to the number of lines that could be added so I don't know if it makes sense to add more lines.

Thank you so much for using the package! When I get a chance I will try to add some more features. Feel free to make submit a PR if you have a feature that you want to add!

ilyinss commented 1 year ago

I sent you one more issue. I’m not very skilled in R ( just plots/ regressions / shiny) but if you want, I can help you with library.

Thank you.

Sergey

On 6 Mar 2023, at 19:25, Benjamin Smith @.***> wrote:

@ilyinss https://github.com/ilyinss I see.

Thats definitely a good idea. Maybe I should make a separate function which allows for a specific lon/lat coordinate to be specified.

As far as the other ideas are concerned:

More colors are definitely invited. If you have a specific set of colors in mind let me know and I can make them. Alternatively I could create a seperate function which allows for users to specify primary and secondary colors.

More text fonts are also a good idea. Maybe it could also be added in this new function.

There is no end to the number of lines that could be added so I don't know if it makes sense to add more lines.

Thank you so much for using the package! When I get a chance I will try to add some more features. Feel free to make submit a PR if you have a feature that you want to add!

— Reply to this email directly, view it on GitHub https://github.com/benyamindsmith/starBliss/issues/12#issuecomment-1456448968, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKPWDFDAO36FDTOXY66PBQTW2YFWLANCNFSM6AAAAAAVQPY7HY. You are receiving this because you were mentioned.

benyamindsmith / starBliss

can you add a lat/long location method? #12