berk / will_filter

rails engine plugin for filtering active_record model objects
MIT License
157 stars 76 forks source link

Adds :via => to routes for rails 4 compatability #45

Closed noahpryor closed 11 years ago

noahpryor commented 11 years ago

rails 4 won't let you do a wild card match anymore, so I added :via => [:get,:post] etc to the necessary routes.

jonaseichhorst commented 11 years ago

Any chances of this happening? Facing the same issue...

noahpryor commented 11 years ago

If you use my fork as your base, e.g.

gem 'will_filter', github: 'noahpryor/will_filter'

and add strong parameters(or move everything from attr_accessible to strong_parameters) and kaminari to your gemfile it should work with rails 4.

here's an example app I just whipped with rail4 with my fork installed and working https://github.com/noahpryor/will_filter_test

jonaseichhorst commented 11 years ago

Thanks, that's great, really appreciate your help! On Sep 5, 2013 7:37 PM, "Noah Pryor" notifications@github.com wrote:

If you use my fork as your base, e.g.

gem 'will_filter', github: 'noahpryor/will_filter'

and add strong parameters(or move everything from attr_accessible to strong_parameters) and kaminari to your gemfile it should work with rails 4.

here's an example app I just whipped with rail4 with my fork installed and working https://github.com/noahpryor/will_filter_test

— Reply to this email directly or view it on GitHubhttps://github.com/berk/will_filter/pull/45#issuecomment-23861472 .

chipairon commented 11 years ago

Thanks @noahpryor, @berk Do you have any reason not to merge this so we can use this gem with Rails 4?? Thanks

berk commented 11 years ago

@noahpryor and @Chipairon thank you for the fix. I will release the new gem later today.