search

berrywhite96 / lovelace-shutter-row

Home Assistant Lovelace Shutter Row Card
MIT License
19 stars 4 forks source link

Improvements? #13

Closed SanderM2 closed 1 year ago

SanderM2 commented 1 year ago

  1. I'm used to the HA default cover card which includes an UP and DOWN arrow. Your card displays a circumflex symbol (and one upside-down) which is much smaller to press on small smartphone. This is less handy for me and is holding me back for now. I myself would prefer the default UP and DOWN arrow or an equivalent. Picture: pic1

  2. I also noticed that your card does not have a on mouse hover action like the default HA cover card has. (It doesn't color the background of the hovered item and no popup is shown. Picture: pic2

  3. With the default HA cover card you get an UP or DOWN arrow while the cover is running. This arrow indicates in which direction the cover is currently running. I'm missing this feature in your card? Picture: pic3 pic4

Finally: I wonder if you would be interested in supporting these ( https://github.com/queimadus/cover-icon-element ) icons? They included an UP/DOWN arrow (see point 3 above) and they also have 5 different icons which should be shown depending on the current position of the cover.

SanderM2 commented 1 year ago

I changed all icons (opening, closing, and different icons for positions <25%, <50% and <75%) + changed icons for up/stop/down. My modified version can be found here: https://raw.githubusercontent.com/SanderM2/lovelace-shutter-row/main/shutter-row.js

I'm not sure if this is something you would like to adapt to your version? If not, I'll have to continue with a custom modified version instead.

But these icons can probably easily be made adjustable from config?

berrywhite96 commented 1 year ago

First thanks for the suggestions!

  1. I'm used to the HA default cover card which includes an UP and DOWN arrow. Your card displays a circumflex symbol (and one upside-down) which is much smaller to press on small smartphone. This is less handy for me and is holding me back for now. I myself would prefer the default UP and DOWN arrow or an equivalent.

These aren't circumflex symbols. If you go into the source code you will see these are just different direction icons, because I just don't want to copy paste the vanilla cover card (I know it's very similar, but at least it's something).

The symbols aren't smaller if you can see in the picture below. d

  1. I also noticed that your card does not have a on mouse hover action like the default HA cover card has. (It doesn't color the background of the hovered item and no popup is shown.

Hovers are nice, this is something I could add in the future.

  1. With the default HA cover card you get an UP or DOWN arrow while the cover is running. This arrow indicates in which direction the cover is currently running. I'm missing this feature in your card?

Finally: I wonder if you would be interested in supporting these ( https://github.com/queimadus/cover-icon-element ) icons? They included an UP/DOWN arrow (see point 3 above) and they also have 5 different icons which should be shown depending on the current position of the cover.

These icons look nice, but the repo owner didn't add a license to the repo so I have no right to use these.

But these icons can probably easily be made adjustable from config?

I see no point to add customizable dynamic icons, the entity icon should be enough.

Ra72xx commented 1 year ago

I also like suggestion 3, as the mdi icon set is sorely missing different cover states. Are you sure you need a license in this case? The cover-icon-elemt icons are simple (and obvious) modifications of the standard mdi icons and therefore should have the same license IMHO.

berrywhite96 commented 1 year ago

I also like suggestion 3, as the mdi icon set is sorely missing different cover states. Are you sure you need a license in this case? The cover-icon-elemt icons are simple (and obvious) modifications of the standard mdi icons and therefore should have the same license IMHO.

No, I am not that into legal. But normally you push a license file into your repo, I don't know how it behave if you don't.

jhmeier commented 1 year ago

I changed all icons (opening, closing, and different icons for positions <25%, <50% and <75%) + changed icons for up/stop/down. My modified version can be found here: https://raw.githubusercontent.com/SanderM2/lovelace-shutter-row/main/shutter-row.js

I'm not sure if this is something you would like to adapt to your version? If not, I'll have to continue with a custom modified version instead.

But these icons can probably easily be made adjustable from config?

Hi. I installed shutter row with HACS and replaced the js File with yours - unfortunately even after a restart the icons don't change. Is their anything else that I need to do? Thanks

berrywhite96 commented 1 year ago

Released with v0.3.0.