search

berrywhite96 / lovelace-shutter-row

Home Assistant Lovelace Shutter Row Card
MIT License
19 stars 4 forks source link

state_color problem #15

Closed miguelpucela closed 1 year ago

miguelpucela commented 1 year ago

Thank you for this great card!

The issue I've found is the next:

When I set the position of a shutter different from 0, and state_color is set to true, the icon is yellow indefinitely. Only if position is 0 the icon returns to blue.

berrywhite96 commented 1 year ago

Thanks!

I mean it's active if it's not fully closed, I don't see the problem here.

miguelpucela commented 1 year ago

Ah, ok. I understood that active mean that the shutter was moving.

Then, there's no issue about that.

maorcc commented 1 year ago

@berrywhite96, I also understood at first that "active" means that the shutter is either currently opening or closing. I had to look at the source code to understand what "active" means "not closed".

I suggest modifying the README.md text to say, "Enables icon coloring if the shutter is not fully closed"