search

bespoke-silicon-group / basejump_stl

BaseJump STL: A Standard Template Library for SystemVerilog
http://bjump.org/
Other
518 stars 99 forks source link

counter can not overflow in bsg_counter_overflow_en #129

Open leonardxiang opened 5 years ago

leonardxiang commented 5 years ago

The counter pointer in this module can not hit the value of power of 2.

leonardxiang commented 5 years ago

Hello, @stdavids I create this issue here.

RicoLi424 commented 1 year ago

Hi Scott, I ran into the same issue as Leonard when setting max_val_p as 2^n. It seems the code has still not been updated to _BSG_WIDTH_ or max_val_p+1 which can fix this issue. @stdavids

taylor-bsg commented 1 year ago

Hi Rico,

You can submit a pull request

On Thu, Sep 7, 2023 at 2:02 AM Rico @.***> wrote:

Hi Scott, I ran into the same issue as Leonard when setting max_val_p as 2^n. It seems the code has still not been updated to BSG_WIDTH or max_val_p+1 which can fix this issue. @stdavids https://github.com/stdavids

— Reply to this email directly, view it on GitHub https://github.com/bespoke-silicon-group/basejump_stl/issues/129#issuecomment-1709768221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFG5AAPZ3HECYXWE7XUUM3XZGES3ANCNFSM4ILVZH6A . You are receiving this because you are subscribed to this thread.Message ID: @.***>