search

bespoke-silicon-group / basejump_stl

BaseJump STL: A Standard Template Library for SystemVerilog
http://bjump.org/
Other
471 stars 96 forks source link

[bsg_cache] ready_o -> yumi_o #639

Closed tommydcjung closed 1 year ago

tommydcjung commented 1 year ago

Fixing the input handshaking interface.

farzamgl commented 1 year ago

Is there a reason behind switching from ready to yumi?

tommydcjung commented 1 year ago

It's more suitable to call it yumi_o, because it depends on the input packet and v_i. https://github.com/bespoke-silicon-group/basejump_stl/blob/4958d731df66cd2654738c68192dd642acedec81/bsg_cache/bsg_cache.v#L991

dpetrisko commented 1 year ago

https://github.com/bespoke-silicon-group/basejump_stl/issues/605

See here (and linked issue) for further discussion

farzamgl commented 1 year ago

Makes sense. The changes look good.

taylor-bsg commented 1 year ago

Looping in @BrendenPage to sign off on it =)

BrendenPage commented 1 year ago

Looks good to me!

taylor-bsg commented 1 year ago

@BrendenPage do you have to pull these changes into BaseJump STL 2.0?

BrendenPage commented 1 year ago

@BrendenPage do you have to pull these changes into BaseJump STL 2.0?

I was considering merging the master branch into Basejump 2.0 along with these changes but I can specifically pull this branch in instead if that's better @taylor-bsg.