search

bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

Set Start Time on Friday Conference Schedule to 4pm? #133

Closed burlexpo closed 10 years ago

burlexpo commented 10 years ago

This is a "nice to have", not a bug.

Is it possible to have the schedules not render a row if there is absolutely nothing in it? i.e., the first Conference sessions on Friday are at 4:30PM. Why are we rendering 8am to 4pm?

jonkiparsky commented 10 years ago

That looks like a build issue. I'm passing in the start time of the conference as a parameter, so it should be starting at noon on Friday(which was an existing value in the code - can change to 4PM easily enough.

burlexpo commented 10 years ago

OK -- let's be careful here.

We want the start time to be 4pm on Friday on the Conference schedule, and 8am on Saturday and Sunday.

We want it to be 8am every day on the Volunteer Schedule

We could have it be 7pm every day on the show schedule. Takes up less real estate.

On 12/21/13 9:47 PM, Jon Kiparsky wrote:

That looks like a build issue. I'm passing in the start time of the conference as a parameter, so it should be starting at noon on Friday(which was an existing value in the code - can change to 4PM easily enough.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/133#issuecomment-31077588.

burlexpo commented 10 years ago

Whoops! Forget the Events schedule --

Friday: start at 6pm Saturday: Start at 8am Sunday: Start at 8am

On 12/21/13 9:47 PM, Jon Kiparsky wrote:

That looks like a build issue. I'm passing in the start time of the conference as a parameter, so it should be starting at noon on Friday(which was an existing value in the code - can change to 4PM easily enough.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/133#issuecomment-31077588.

jonkiparsky commented 10 years ago

Currently the code has one value for start time for each day, but that's not in stone. Shouldn't be a problem to do it this way. Each day has a start time for Conf, Vol, and Show.

On Sat, Dec 21, 2013 at 9:51 PM, Scratch notifications@github.com wrote:

OK -- let's be careful here.

We want the start time to be 4pm on Friday on the Conference schedule, and 8am on Saturday and Sunday.

We want it to be 8am every day on the Volunteer Schedule

We could have it be 7pm every day on the show schedule. Takes up less real estate.

On 12/21/13 9:47 PM, Jon Kiparsky wrote:

That looks like a build issue. I'm passing in the start time of the conference as a parameter, so it should be starting at noon on Friday(which was an existing value in the code - can change to 4PM easily enough.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/133#issuecomment-31077588.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/133#issuecomment-31077646 .

bethlakshmi commented 10 years ago

Scratch, can you give a relative priority on this?

If not, I think we agreed that we need Reg to start at noon, Fri. If you disagree, I'm OK with working fewer shifts, but that 's the earliest we need people.

If we go with the idea of "not showing lots of empty cells on tables", I'd rather get the schedule display to do a clever way of skipping empty rows than trying to change the constants for convention start and end times. Those constants are riddled through the code and will require a LOT of retesting.

jonkiparsky commented 10 years ago

Okay. I've marked empty rows with the class "empty" and put a line in schedule.js to hide tr elements with the class "empty". That's going to make the schedules look a little weird, but there you go.

jonkiparsky commented 10 years ago

@bethlakshmi please review and close

bethlakshmi commented 10 years ago

Love the new look.