bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

Overlapping Events in Same Room #145

Open burlexpo opened 10 years ago

burlexpo commented 10 years ago

If you schedule two things in the same place at the same time, one of the events (the newer one, I think) displays in the next column over -- even though when you click on the link, the information about where the event is taking place is accurate.

Take a look at http://www.testexpo.firstladyofburlesque.com/Schedule.php?action=24&displayType=Volunteer (Volunteer, Saturday) and the event "Overlap Test". it's supposed to be in the Theater; it displays as though it's in The Vendor Hall.

burlexpo commented 10 years ago

This is pretty urgent.

jonkiparsky commented 10 years ago

I'd think you shouldn't be able to schedule two events in the same place at the same time. Is there a use case for this? If so, how would you like it to display?

On Thu, Jan 9, 2014 at 11:39 PM, Scratch notifications@github.com wrote:

This is pretty urgent.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32002270 .

burlexpo commented 10 years ago

From a design POV, I'd just like the different events in the same space and time to be listed in the same timeslot with bullets ahead of them. I know this can make for some big hour blocks. Sample attached...

screen shot 2014-01-09 at 11 53 46 pm

jonkiparsky commented 10 years ago

This is possible, I think, but it might be a big change. Is this something you expect to need? If so, I'll get on it.

On Thu, Jan 9, 2014 at 11:54 PM, Scratch notifications@github.com wrote:

From a design POV, I'd just like the different events in the same space and time to be listed in the same timeslot with bullets ahead of them. I know this can make for some big hour blocks. Sample attached...

[image: screen shot 2014-01-09 at 11 53 46 pm]https://f.cloud.github.com/assets/5369404/1884893/3ee89766-79b3-11e3-95f6-5e6b68d9e67a.png

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32002690 .

bethlakshmi commented 10 years ago

Scratch and I talked on the phone. The need to have multilple volunteer slots in one room is urgent, but we found a work around for right now. In the very short term - can you update the jquery for the calendar to NOT show 'volunteer' - in a longer term, a calendar that shows 2 things in 1 place at the same time is a requirement that we need to add to the system.

jonkiparsky commented 10 years ago

Disabling volunteer is easy, i can do that when i get home. I'll also have a look at the multiple events problem then and give a better estimate of the difficulty

burlexpo commented 10 years ago

How we doing on disabling the Volunteer tab on the visual schedule display? Betty just pushed some changes and it doesn't look like you've had a chance to disable it yet.

On 1/11/14 12:46 PM, Jon Kiparsky wrote:

Disabling volunteer is easy, i can do that when i get home. I'll also have a look at the multiple events problem then and give a better estimate of the difficulty

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32102178.

jonkiparsky commented 10 years ago

Committed. Sorry, I've been out all day. This is a quick fix - there's a blank spot in the selector table, and if someone clicks on it, nothing shows. If the revamp for the sched tables is going to take more than a few days, I'll do something more elaborate (so there isn't a weird empty button).

On Sat, Jan 11, 2014 at 9:59 PM, Scratch notifications@github.com wrote:

How we doing on disabling the Volunteer tab on the visual schedule display? Betty just pushed some changes and it doesn't look like you've had a chance to disable it yet.

On 1/11/14 12:46 PM, Jon Kiparsky wrote:

Disabling volunteer is easy, i can do that when i get home. I'll also have a look at the multiple events problem then and give a better estimate of the difficulty

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32102178.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32113868 .

jonkiparsky commented 10 years ago

Okay, this one is looking like a bit of a bastard. Among other things, I have to deal with the possibility that we have two or several events not contiguous in time, but overlapping in the same room. For example, event 1 starts at noon and extends to 2 PM. Event 2 in the same room goes from 12:30 to 1:30. Or event 3 starts at 1:30 and extends to 2:30, still in the same room. Or events 1,2, and 3 are all present. How the hell does that look? @burlexpo, any ideas on how to handle overlaps of this sort? However it looks in the UI, this is probably a complete rework of the schedule display. So while I'm at it, if there's any other requirements that are going to crop up, I'd really really like to know about it now so I can incorporate them now.

jonkiparsky commented 10 years ago

Fixed.

jonkiparsky commented 10 years ago

Restored volunteer tab.

burlexpo commented 10 years ago

Awesome! 99% of the way there. There are some events that are not meant to be displayed (Technical Rehearsals or Act Rehearsals; I'm not sure which -- but Betty knows) and have been flagged by Betty in some way that they didn't appear in the list format. She' can tell you what to look for to render an event invisible and then this will be ready for prime-time. Looks great!

bethlakshmi commented 10 years ago

The bug isn't in Jon's code, it's in the data. For some reason, the act rehearsals didn't get stored in non-viewable mode. I'm sure the bug is in my logic somewhere but for the interest of expediency, I'm going to manually fix.

burlexpo commented 10 years ago

Ok. Thanks. Once you've fixed it, since it shouldn't come up again, can you push Jon's changes up?

On 1/20/14 5:14 PM, bethlakshmi wrote:

The bug isn't in Jon's code, it's in the data. For some reason, the act rehearsals didn't get stored in non-viewable mode. I'm sure the bug is in my logic somewhere but for the interest of expediency, I'm going to manually fix.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32802197.

bethlakshmi commented 10 years ago

Done. Pushed. Please see what you think.

bethlakshmi commented 10 years ago

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

jonkiparsky commented 10 years ago

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600 .

burlexpo commented 10 years ago

Betty can probably answer this better than I can.

We're going to do /something/ with this code after the event ends. The 'something' may be 'burn it down and start all over again', but I doubt it (and I hope not). It may also be, 'use what we can and improve the rest'.

Right now, we just want it to do what we want.

On 1/20/14 6:21 PM, Jon Kiparsky wrote:

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600 .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32806987.

jonkiparsky commented 10 years ago

The reason I ask is because the easy answer to this new requirement will make maintenance down the road more difficult - basically, adding a small but ultimately noticeable quantum to the sludge factor. A more responsible solution may be possible, but it will require significantly more work in the immediate term. If this code base has a life beyond next month, then that work will have to be be done for this requirement to be met. Therefore it should be done now. If on the other hand this code base is for scrap heap - which would be my fervent hope - then I can get this thing done in an hour or so in a way that will get us through the end of the event, and then never look at it again.

So which should I do?

(the other requirement of this fix is that we actually do know that there will not be Conference or Event items doubled up in the same room/time slot

On Mon, Jan 20, 2014 at 6:56 PM, Scratch notifications@github.com wrote:

Betty can probably answer this better than I can.

We're going to do /something/ with this code after the event ends. The 'something' may be 'burn it down and start all over again', but I doubt it (and I hope not). It may also be, 'use what we can and improve the rest'.

Right now, we just want it to do what we want.

On 1/20/14 6:21 PM, Jon Kiparsky wrote:

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600>

.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32806987.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32809025 .

burlexpo commented 10 years ago

I can't answer the first part, but I can answer this part --

(the other requirement of this fix is that we actually do know that there will not be Conference or Event items doubled up in the same room/time slot

  • so we'd better be sure that that's actually true) There ARE Event items doubled-up in the same room/time. If that makes the fix impossible, then so be it.

The display isn't so epically ugly that I want to spend a lot more time on this... especially since we seem to keep running across other bugs.

-=S.

On Mon, Jan 20, 2014 at 6:56 PM, Scratch notifications@github.com wrote:

Betty can probably answer this better than I can.

We're going to do /something/ with this code after the event ends. The 'something' may be 'burn it down and start all over again', but I doubt it (and I hope not). It may also be, 'use what we can and improve the rest'.

Right now, we just want it to do what we want.

On 1/20/14 6:21 PM, Jon Kiparsky wrote:

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600>

.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32806987.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32809025 .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32810706.

jonkiparsky commented 10 years ago

That makes the quick/easy fix impossible, since it was simply to bring the previous code back in and run it alongside the new code - new code for the Vol table, previous for Conf and Events. Since that's not going to fly, it'd have to be a little more complex. Difficult.

On Mon, Jan 20, 2014 at 8:17 PM, Scratch notifications@github.com wrote:

I can't answer the first part, but I can answer this part --

(the other requirement of this fix is that we actually do know that there will not be Conference or Event items doubled up in the same room/time slot

  • so we'd better be sure that that's actually true) There ARE Event items doubled-up in the same room/time. If that makes the fix impossible, then so be it.

The display isn't so epically ugly that I want to spend a lot more time on this... especially since we seem to keep running across other bugs.

-=S.

On Mon, Jan 20, 2014 at 6:56 PM, Scratch notifications@github.com wrote:

Betty can probably answer this better than I can.

We're going to do /something/ with this code after the event ends. The 'something' may be 'burn it down and start all over again', but I doubt it (and I hope not). It may also be, 'use what we can and improve the rest'.

Right now, we just want it to do what we want.

On 1/20/14 6:21 PM, Jon Kiparsky wrote:

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600>

.

— Reply to this email directly or view it on GitHub <https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32806987 .

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32809025> .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32810706.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32813020 .

burlexpo commented 10 years ago

Skip it. At the risk of repeating myself ;-)

The display isn't so epically ugly that I want to spend a lot more time on this... especially since we seem to keep running across other bugs.

On 1/20/14 8:21 PM, Jon Kiparsky wrote:

That makes the quick/easy fix impossible, since it was simply to bring the previous code back in and run it alongside the new code - new code for the Vol table, previous for Conf and Events. Since that's not going to fly, it'd have to be a little more complex. Difficult.

On Mon, Jan 20, 2014 at 8:17 PM, Scratch notifications@github.com wrote:

I can't answer the first part, but I can answer this part --

(the other requirement of this fix is that we actually do know that there will not be Conference or Event items doubled up in the same room/time slot

  • so we'd better be sure that that's actually true) There ARE Event items doubled-up in the same room/time. If that makes the fix impossible, then so be it.

The display isn't so epically ugly that I want to spend a lot more time on this... especially since we seem to keep running across other bugs.

-=S.

On Mon, Jan 20, 2014 at 6:56 PM, Scratch notifications@github.com wrote:

Betty can probably answer this better than I can.

We're going to do /something/ with this code after the event ends. The 'something' may be 'burn it down and start all over again', but I doubt it (and I hope not). It may also be, 'use what we can and improve the rest'.

Right now, we just want it to do what we want.

On 1/20/14 6:21 PM, Jon Kiparsky wrote:

Probably could do. Before I say yes or no, I have to know if there's any danger of this code ever being used for anything after the conference finishes. If the answer is no, then I'm willing to do a cheap stupid fix that'll get us to the event. But if this stuff will ever be used after the event, then the cheap stupid fix will just make things worse, not better, so I don't want to do that. Basically, the question is are we in duct tape and chewing gum mode, or are we trying to maintain something that has a life beyond February?

On Mon, Jan 20, 2014 at 5:33 PM, bethlakshmi notifications@github.comwrote:

This might be crazy... but is there a way when there isn't a conflict to display events the snazzy old way, where they blocked off rows for the # of blocks they were filling - so a 2 hour event showed up in a big box? That's true for Conference and Events...

Feel free to say no. I told Scratch there were only so many ways we could slice and dice something that is supposed to be single comprehensible chunk of code.

Nice Fix though!

— Reply to this email directly or view it on GitHub<

https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32803600>

.

— Reply to this email directly or view it on GitHub

<https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32806987 .

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32809025> .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32810706.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/145#issuecomment-32813020 .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/145#issuecomment-32813223.