search

bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

"Invalid Start Time" applied incorrectly #153

Closed burlexpo closed 10 years ago

burlexpo commented 10 years ago

I'm trying to create an Ops event for Stage Kittening the Bordello. I created the entry with a start time of 10:30pm, filled out all the information, but when I click submit, I get an error which reads

Invalid start time (time = 01:00 AM) specified for Fri.Valid times are 12:00 PM to 12:00 AM.

image

jonkiparsky commented 10 years ago

Time is in my bailiwick. I'll take a look.

burlexpo commented 10 years ago

On 1/20/14 8:58 PM, Jon Kiparsky wrote:

Time is in my bailiwick. I'll take a look.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32814848.

Thanks, Jon.

Other events seem to build just fine. This is a weird one...

jonkiparsky commented 10 years ago

It looks like it's the end time that's the problem: midnight is the last time we can talk about on the current order of things. I could try to modify that, but that might be a little tricky, or we could remove the end-time check, which would require a little tweaking but is probably easier to do.

jonkiparsky commented 10 years ago

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

bethlakshmi commented 10 years ago

I'm good either way

On Tuesday, January 21, 2014, Jon Kiparsky notifications@github.com wrote:

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/153#issuecomment-32823193 .

burlexpo commented 10 years ago

Ah-ha!

So... what we have here is a failure to communicate ;-)

The problem was, I was starting events at 10:30pm which is /inside/ the clearly posted allowable time frame plus I was getting an error telling me I couldn't start an event at 1:00 a.m. (which I wasn't doing).

So, all events must end by midnight. Got it. That's fine. It's really just one or two events, and I can make a note in the description with the actual end time.

I'll close this one and maybe we'll fix it later.

-=S.

On 1/21/14 12:48 AM, Jon Kiparsky wrote:

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32823193.

bethlakshmi commented 10 years ago

Just a quick commment for the GitHub (keeper of my brain)....

The original design had a very.... interesting context. They had a delineation of

This was good in the sense of multiple runs - you could always assume that if you did the same thing over again, you'd have the same length but different start day & time.

All was well in this context until you factor in that they also decided that a "day" didn't have to end at midnight. So the original context was that you could set a day (let's call it Friday) to start at noon, and end at 4:00 in the morning when the wild party was over. So they redefined the allowed ranges of "start time" and also put in a bunch of business logic and fixed constants all over the place to handle the problem of not letting an event go beyond the day's allowed time.

This is a level where things get crazier and crazier. In next year's design I'd advocate that we consider "start time" and "end time" and not worry about "length" as it's own value (length = end - start)

On Tue, Jan 21, 2014 at 9:27 AM, Scratch notifications@github.com wrote:

Ah-ha!

So... what we have here is a failure to communicate ;-)

The problem was, I was starting events at 10:30pm which is /inside/ the clearly posted allowable time frame plus I was getting an error telling me I couldn't start an event at 1:00 a.m. (which I wasn't doing).

So, all events must end by midnight. Got it. That's fine. It's really just one or two events, and I can make a note in the description with the actual end time.

I'll close this one and maybe we'll fix it later.

-=S.

On 1/21/14 12:48 AM, Jon Kiparsky wrote:

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32823193.

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/153#issuecomment-32889156 .

jonkiparsky commented 10 years ago

As long as we're thinking about future design, I'd prefer to use actual date and time objects and not ad hoc integers.

That would make me very happy.

On the current issue, I'm thinking I can actually extend the day past midnight. I'll try to execute that later tonight, and will commit if it works. What time should the day end, if I manage this? 1 AM? 2 AM?

On Tue, Jan 21, 2014 at 4:05 PM, bethlakshmi notifications@github.comwrote:

Just a quick commment for the GitHub (keeper of my brain)....

The original design had a very.... interesting context. They had a delineation of

  • Days
  • Start Time
  • Length

This was good in the sense of multiple runs - you could always assume that if you did the same thing over again, you'd have the same length but different start day & time.

All was well in this context until you factor in that they also decided that a "day" didn't have to end at midnight. So the original context was that you could set a day (let's call it Friday) to start at noon, and end at 4:00 in the morning when the wild party was over. So they redefined the allowed ranges of "start time" and also put in a bunch of business logic and fixed constants all over the place to handle the problem of not letting an event go beyond the day's allowed time.

This is a level where things get crazier and crazier. In next year's design I'd advocate that we consider "start time" and "end time" and not worry about "length" as it's own value (length = end - start)

On Tue, Jan 21, 2014 at 9:27 AM, Scratch notifications@github.com wrote:

Ah-ha!

So... what we have here is a failure to communicate ;-)

The problem was, I was starting events at 10:30pm which is /inside/ the clearly posted allowable time frame plus I was getting an error telling me I couldn't start an event at 1:00 a.m. (which I wasn't doing).

So, all events must end by midnight. Got it. That's fine. It's really just one or two events, and I can make a note in the description with the actual end time.

I'll close this one and maybe we'll fix it later.

-=S.

On 1/21/14 12:48 AM, Jon Kiparsky wrote:

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32823193.

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32889156> .

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/153#issuecomment-32963236 .

bethlakshmi commented 10 years ago

My random thought = 2:00 - and keep it consistent for Fri, Sat & Sun.

If the Rhinestone review lasts much longer, I think we will kill our volunteers.

Chances are QUITE good that Sunday night strike will run later than 2:00 on Sunday - but I think instead of a website fix, I think we make super-late-night strike crew a special event that mentions that some really excellent treats will be available for those who hang in there until the bitter end and that we don't know exactly when "bitter end" will be.

(I will gladly volunteer to find and bring at least 1 form of delicious treat (possibly alcoholic in nature, and definitely not good for anyone))

-Betty

On Tue, Jan 21, 2014 at 4:09 PM, Jon Kiparsky notifications@github.comwrote:

As long as we're thinking about future design, I'd prefer to use actual date and time objects and not ad hoc integers.

That would make me very happy.

On the current issue, I'm thinking I can actually extend the day past midnight. I'll try to execute that later tonight, and will commit if it works. What time should the day end, if I manage this? 1 AM? 2 AM?

On Tue, Jan 21, 2014 at 4:05 PM, bethlakshmi notifications@github.comwrote:

Just a quick commment for the GitHub (keeper of my brain)....

The original design had a very.... interesting context. They had a delineation of

  • Days
  • Start Time
  • Length

This was good in the sense of multiple runs - you could always assume that if you did the same thing over again, you'd have the same length but different start day & time.

All was well in this context until you factor in that they also decided that a "day" didn't have to end at midnight. So the original context was that you could set a day (let's call it Friday) to start at noon, and end at 4:00 in the morning when the wild party was over. So they redefined the allowed ranges of "start time" and also put in a bunch of business logic and fixed constants all over the place to handle the problem of not letting an event go beyond the day's allowed time.

This is a level where things get crazier and crazier. In next year's design I'd advocate that we consider "start time" and "end time" and not worry about "length" as it's own value (length = end - start)

On Tue, Jan 21, 2014 at 9:27 AM, Scratch notifications@github.com wrote:

Ah-ha!

So... what we have here is a failure to communicate ;-)

The problem was, I was starting events at 10:30pm which is /inside/ the clearly posted allowable time frame plus I was getting an error telling me I couldn't start an event at 1:00 a.m. (which I wasn't doing).

So, all events must end by midnight. Got it. That's fine. It's really just one or two events, and I can make a note in the description with the actual end time.

I'll close this one and maybe we'll fix it later.

-=S.

On 1/21/14 12:48 AM, Jon Kiparsky wrote:

Or I suppose I could leave the code as is and you could quit trying to schedule things outside of the clearly posted allowable time frames.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32823193.

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32889156> .

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/153#issuecomment-32963236> .

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/153#issuecomment-32963631 .

jonkiparsky commented 10 years ago

Fixed. All days close at 2:00 AM.