bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

Add image to Fashion Show page? #155

Open burlexpo opened 10 years ago

burlexpo commented 10 years ago

I tried doing an in the source code, but something strips images out.

I'd love to get this logo

http://cs.undercoverwear.com/pwsdata/UCW/ContentImages/UndercoverWear_valentine.jpg

on this event's page

http://burlesque-expo.com/Schedule.php?action=25&EventId=22&RunId=22

jonkiparsky commented 10 years ago

I just added it in the ckeditor. Let's see if it persists.

On Thu, Jan 23, 2014 at 12:22 PM, Scratch notifications@github.com wrote:

I tried doing an http://.... in the source code, but something strips images out.

I'd love to get this logo

http://cs.undercoverwear.com/pwsdata/UCW/ContentImages/UndercoverWear_valentine.jpg

on this event's page

http://burlesque-expo.com/Schedule.php?action=25&EventId=22&RunId=22

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/155 .

jonkiparsky commented 10 years ago

Seems to have worked. Closing this.

burlexpo commented 10 years ago

I'd like to re-open this. I don't know how you got the image to display on that page, Jon, but it wasn't what I was trying to do and I need an easy way to add images to the site.

What I want to be able to do, for example is open the source of an event (let's say http://burlesque-expo.com/Schedule.php?action=25&EventId=157), using the on-site editor (so http://burlesque-expo.com/SpecialEvents.php?action=40&RunId=234), and include HTML that looks like this...

"Who knew that burlesque could actually represent family values and a return to wholesome entertainment?" – The World Famous Pontani Sisters.

From performances on network television to the fabulous showrooms of Las Vegas, to clubs and festivals around the world, these Showy and 5'2" performers are a modern day burlesque act you can bring the whole family to see. See how these old-fashioned girls, called "Curvaceous punk rock Rockettes" by the Philadelphia Weekly and "Glamorous Italian Stallions that live up to the 'World Famous' part of their name" by the Village Voice, sparked the renaissance of modern burlesque, while following their mission to bring glamour back to entertainment.

One of the earliest documentaries on the neo-burlesque revival, Rebecca Shapiro's Showy & 5'2" is rarely shown.  Don't miss this opportunity to see this inside peek into America's first family of burlesque – plus chat with the star, Angie Pontani, afterward!

and have the image referred to in the <img src ...> in the first line show up, instead of being automatically stripped out of the code.

burlexpo commented 10 years ago

Crap. Of course, my comment doesn't display the way I want it to... GitHub doesn't seem to have a way to display plain text.

jonkiparsky commented 10 years ago

All I did was paste in a link tag wrapped around an img tag. When I hit submit, the image was there, but the editor didn't show the html I'd added when I went to look.

So the problem is somewhere in the ckeditor - probably some configuration thing. The story as I'm imagining it goes:It's accepting the html source, but not displaying it when it refreshes. So the html goes into the database, but it's not shown in the editor.

If you construct the html you want, and paste it in, it should work. To replace, just redo. The real problem is that if you edit that event's text, you're going to lose the image and link - and yes, this is a problem, so this needs attention, but you should be able to get an image up right now - just put the html in (ie, Foo bar baz ), save the changes. You won't see the html in the editor, but you should see it on the site.

I'll take a look at the ckeditor configuration and see if I can learn anything about how to resolve this properly.

On Tue, Jan 28, 2014 at 10:39 AM, Scratch notifications@github.com wrote:

Reopened #155 https://github.com/bethlakshmi/GBE/issues/155.

Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/155 .

jonkiparsky commented 10 years ago

" GitHub doesn't seem to have a way to display plain text."

Try this:

Fenced code blocks

Standard Markdown converts text with four spaces at the beginning of each line into a code block; GFM also >supports fenced blocks. Just wrap your code in ``` (as shown below) and you won't need to indent it by four spaces. >Note that although fenced code blocks don't need to be preceded by a blank line—unlike indented code blocks—we >recommend placing a blank line before them to make the raw Markdown easier to read.

GitHub uses markdown (the flavor of the month in markup syntax). There's a link to information here: https://help.github.com/articles/github-flavored-markdown

burlexpo commented 10 years ago

Ok, wrapping it in a link tag works -- but, boy is that a hacked solution.

On 1/28/14 11:00 AM, Jon Kiparsky wrote:

All I did was paste in a link tag wrapped around an img tag. When I hit submit, the image was there, but the editor didn't show the html I'd added when I went to look.

So the problem is somewhere in the ckeditor - probably some configuration thing. The story as I'm imagining it goes:It's accepting the html source, but not displaying it when it refreshes. So the html goes into the database, but it's not shown in the editor.

If you construct the html you want, and paste it in, it should work. To replace, just redo. The real problem is that if you edit that event's text, you're going to lose the image and link - and yes, this is a problem, so this needs attention, but you should be able to get an image up right now - just put the html in (ie, Foo bar baz ), save the changes. You won't see the html in the editor, but you should see it on the site.

I'll take a look at the ckeditor configuration and see if I can learn anything about how to resolve this properly.

On Tue, Jan 28, 2014 at 10:39 AM, Scratch notifications@github.com wrote:

Reopened #155 https://github.com/bethlakshmi/GBE/issues/155.

Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/155 .

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/155#issuecomment-33492074.

jonkiparsky commented 10 years ago

But when you didn't wrap it, it didn't work? Interesting.

Okay, so my initial research has found that yes, it's a configuration issue. The ckeditor has an "advanced content filtering" component which is enabled by default, and this filters out html. I'm working on understanding the settings to allow us to use the editor as a CMS. (which is what we're trying to do - not really the standard use case, but we'll see if we can make it work)

jonkiparsky commented 10 years ago

If you're curious, look here: http://burlesque-expo.com/ckeditor/samples/datafiltering.html

jonkiparsky commented 10 years ago

@burlexpo, @bethlakshmi - decision time. Looks like we can configure this to accept any tags at all.

You may, of course, want CKEditor to avoid filtering of any kind. To get rid of ACF, basically set config.allowedContent to true

Doing this will allow you to put in whatever html you want, as far as I can see - but it'll also allow users to do the same. If this is something you're okay with, it's easy to try it. But if you want to restrict users' ability to post images in their bios, then we have a bit more work to do. Let me know if you want me to try this.

bethlakshmi commented 10 years ago

I originally screened this out in how I set up the CKEditor for that very reason - we don't do much checking on user input and I didn't want all kinds of crap coming in with Bid Forms and Bios. So I screened out image upload and some other features.

I'm OK, at this late date, with opening the setting wider - if Scratch is OK with taking the risk. It means that users doing last minute stuff of any kind could really screw up the presentation, but it's unlikely given the low tech saviness level of most of our users.

For next year, I'd advocate running two different editor levels:

For the moment and the right-now urgent need - my opinion is that I don't have much time to help with this, so I will defer to Scratch on what he wants.

-Betty

On Tue, Jan 28, 2014 at 4:12 PM, Jon Kiparsky notifications@github.comwrote:

@burlexpo https://github.com/burlexpo, @bethlakshmihttps://github.com/bethlakshmi- decision time. Looks like we can configure this to accept any tags at all.

You may, of course, want CKEditor to avoid filtering of any kind. To get rid of ACF, basically set config.allowedContent to true

Doing this will allow you to put in whatever html you want, as far as I can see - but it'll also allow users to do the same. If this is something you're okay with, it's easy to try it. But if you want to restrict users' ability to post images in their bios, then we have a bit more work to do. Let me know if you want me to try this.

Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/155#issuecomment-33525919 .

burlexpo commented 10 years ago

Most of our users aren't very tech-savvy...

(ah. Betty's email just came in. What she said).

Please set config.allowedContent to true so I can do interesting things.

Betty, if Jon does this, will you need to push it to the live site? Or can he do it to the live site? There's a ton of stuff I'd love to be able to edit tonight.

-=S

On 1/28/14 4:12 PM, Jon Kiparsky wrote:

@burlexpo https://github.com/burlexpo, @bethlakshmi https://github.com/bethlakshmi - decision time. Looks like we can configure this to accept any tags at all.

You may, of course, want CKEditor to avoid filtering of any kind.
To get rid of ACF, basically set config.allowedContent to true

Doing this will allow you to put in whatever html you want, as far as I can see - but it'll also allow users to do the same. If this is something you're okay with, it's easy to try it. But if you want to restrict users' ability to post images in their bios, then we have a bit more work to do. Let me know if you want me to try this.

— Reply to this email directly or view it on GitHub https://github.com/bethlakshmi/GBE/issues/155#issuecomment-33525919.

jonkiparsky commented 10 years ago

Sorry about the delay - our install doesn't look much like the way it looks in the documentation.

Okay, @bethlakshmi - I've committed a tiny little change to steamtext/header ckeditor has been weird on my box since day one, so I can't really see if it's working. Let me know when you want to push it, and I'll watch to see what happens.