search

bethlakshmi / GBE

Code repository for the Great Boston Burlesque Expo
3 stars 0 forks source link

Time validity check #88

Closed bethlakshmi closed 10 years ago

bethlakshmi commented 10 years ago

I think work on the half hour slot messed with validate_day_time_by_val in intercon_db.inc.

When I try to edit a run of one of the classes in the test site, I get that Saturday at 9:00 AM is not a valid start time, and that the allowed times are 4 PM to midnight.

Actual settings may vary, but should be something close to:

Looking at the current min/max settings in intercon_db, I'm not sure what the deal is - but the settings look odd and I'm not sure when they changed. -Betty

bethlakshmi commented 10 years ago

I just set them back to

// Minimum and maximum times for con days // if these need to be bigger than FRI - 12-31, SAT 8-31, SUN 8-31 // Sun > 16 needs a db reload // then the schema needs to be updated. define (THURS_MIN, 12); // 12 noon define (THURS_MAX, 24); // 7AM define (FRI_MIN, 8); // 12 noon define (FRI_MAX, 24); // 7AM define (SAT_MIN, 8); // 8AM define (SAT_MAX, 24); // 7AM define (SUN_MIN, 8); // 8AM define (SUN_MAX, 24); // 4PM

bethlakshmi commented 10 years ago

Reopening - I see that those settings were set that way for a reason - my calendar now displays oddly on the test site - it looks like the time starts at very, very early in the morning.

So we need a way to reconcile all scheduling GUIs to the new way of calendar display...

jonkiparsky commented 10 years ago

Okay, thanks for finding that. I'll go ahead and fix that while I'm setting up the input to take half-hour times.

On Sun, Nov 10, 2013 at 5:45 PM, bethlakshmi notifications@github.comwrote:

Reopening - I see that those settings were set that way for a reason - my calendar now displays oddly on the test site - it looks like the time starts at very, very early in the morning.

So we need a way to reconcile all scheduling GUIs to the new way of calendar display...

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/88#issuecomment-28163249 .

bethlakshmi commented 10 years ago

FYI - I messed with the allowed times to do some testing yesterday, but I didn't check in in the messing around, so if there's different times in the constants, that's OK, it just needs to be pushed back to the test site.

But if there's different settings, let's put a comment in the code saying what they mean. Now reason to add to the evil. :)

-Betty

On Sun, Nov 10, 2013 at 6:04 PM, Jon Kiparsky notifications@github.comwrote:

Okay, thanks for finding that. I'll go ahead and fix that while I'm setting up the input to take half-hour times.

On Sun, Nov 10, 2013 at 5:45 PM, bethlakshmi notifications@github.comwrote:

Reopening - I see that those settings were set that way for a reason - my calendar now displays oddly on the test site - it looks like the time starts at very, very early in the morning.

So we need a way to reconcile all scheduling GUIs to the new way of calendar display...

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/88#issuecomment-28163249> .

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/88#issuecomment-28163684 .

jonkiparsky commented 10 years ago

Unfortunately, there seems to be some gears grinding here. I'm not understanding the implications of this comment - what is it we need to do with the schema to make this work? Any ideas?

On Mon, Nov 11, 2013 at 11:11 AM, bethlakshmi notifications@github.comwrote:

FYI - I messed with the allowed times to do some testing yesterday, but I didn't check in in the messing around, so if there's different times in the constants, that's OK, it just needs to be pushed back to the test site.

But if there's different settings, let's put a comment in the code saying what they mean. Now reason to add to the evil. :)

-Betty

On Sun, Nov 10, 2013 at 6:04 PM, Jon Kiparsky notifications@github.comwrote:

Okay, thanks for finding that. I'll go ahead and fix that while I'm setting up the input to take half-hour times.

On Sun, Nov 10, 2013 at 5:45 PM, bethlakshmi notifications@github.comwrote:

Reopening - I see that those settings were set that way for a reason - my calendar now displays oddly on the test site - it looks like the time starts at very, very early in the morning.

So we need a way to reconcile all scheduling GUIs to the new way of calendar display...

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/88#issuecomment-28163249> .

— Reply to this email directly or view it on GitHub< https://github.com/bethlakshmi/GBE/issues/88#issuecomment-28163684> .

— Reply to this email directly or view it on GitHubhttps://github.com/bethlakshmi/GBE/issues/88#issuecomment-28212858 .

jonkiparsky commented 10 years ago

@bethlakshmi I think this should be fixed now. Please verify/review.

jonkiparsky commented 10 years ago

Closing this, since testing has produced more granular issues to work with.